Make semantic text part of the text family#119792
Conversation
|
Hi @Mikep86, I've created a changelog YAML for you. |
| "Field [" + fieldType.name() + "] of type [" + fieldType.typeName() + "] does not support match queries" | ||
| "Field [" | ||
| + fieldType.name() | ||
| + "] of type [" | ||
| + fieldType.typeName() | ||
| + "] does not support " | ||
| + type.getQueryName() | ||
| + " queries" |
There was a problem hiding this comment.
I changed this error message because it is propagated through to Kibana when attempting to run a match_phrase query on a semantic_text field. Previously, the error message indicated that semantic_text fields do not support match queries, which was quite misleading.
kderusso
left a comment
There was a problem hiding this comment.
LGTM but I will leave it for an ES|QL expert to 👍
| * The text is analyzed and terms are added to a boolean query. | ||
| */ | ||
| BOOLEAN(0), | ||
| BOOLEAN(0, org.elasticsearch.index.query.MatchQueryBuilder.NAME), |
There was a problem hiding this comment.
Nitpick: Can we clean up imports a bit here, so we don't reference the full class name here?
There was a problem hiding this comment.
Can't, there's an inner class called MatchQueryBuilder in MatchQueryParser
There was a problem hiding this comment.
Maybe break it out into a variable then?
|
@elasticmachine merge upstream |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: Ioana Tagirta <ioana.tagirta@elastic.co> (cherry picked from commit 29e1bf9) # Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java # x-pack/plugin/esql/qa/testFixtures/src/main/resources/semantic_text.csv-spec
Update field caps to report semantic text as a text field. This change should allow semantic text to more easily integrate with both Kibana and ES|QL, in addition to other components that use field caps to determine how to query a field.