Add support for aggregations, GROK and DISSECT for semantic_text#117337
Merged
ioanatia merged 4 commits intoelastic:mainfrom Nov 25, 2024
Merged
Add support for aggregations, GROK and DISSECT for semantic_text#117337ioanatia merged 4 commits intoelastic:mainfrom
ioanatia merged 4 commits intoelastic:mainfrom
Conversation
16 tasks
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
carlosdelest
approved these changes
Nov 22, 2024
Member
carlosdelest
left a comment
There was a problem hiding this comment.
💯 Thorough work, thank you Ioana
tteofili
approved these changes
Nov 25, 2024
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…stic#117337) * Add support for aggregations for semantic_text * Add capability to csv tests for grok and dissect * Sort values to avoid flaky tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in #115103
Follow up from #115243 where we the main focus was support for functions.
I still needed to go through the commands list and figure out which ones should support semantic_text, which ones are tested already and which ones need a fix.
This left us with:
COUNT/COUNT_DISTINCT/MIN/MAX/TOPover semantic_text fields. I fixed this and for bwc I added an ESQL capabilitysemantic_text_aggregations(similar to [ESQL] Enable "any type" aggregations on Date Nanos #114438)The rest of the documented commands (
DROP,KEEP,MV_EXPAND,SORTetc) should already be tested.I hope that with this we can be close to conclude support for
semantic_textas a field type in ES|QL and to focus onsemantic_textsupport inmatch.