Fix leaking listener in Netty4HttpRequestBodyStream#112629
Merged
mhl-b merged 1 commit intoelastic:partial-rest-requestsfrom Sep 9, 2024
Merged
Fix leaking listener in Netty4HttpRequestBodyStream#112629mhl-b merged 1 commit intoelastic:partial-rest-requestsfrom
mhl-b merged 1 commit intoelastic:partial-rest-requestsfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 17, 2024
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 18, 2024
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 18, 2024
Tim-Brooks
pushed a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Sep 19, 2024
Tim-Brooks
added a commit
that referenced
this pull request
Sep 20, 2024
This commit back ports all of the work introduced in: #113044 * #111438 - 5e1f655 * #111865 - 478baf1 * #112179 - 1b77421 * #112227 - cbcbc34 * #112267 - c00768a * #112154 - a03fb12 * #112479 - 95b42a7 * #112608 - ce2d648 * #112629 - 0d55dc6 * #112767 - 2dbbd7d * #112724 - 58e3a39 * dce8a0b * #112974 - 92daeeb * 529d349 * #113161 - e3424bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently every instance of
Netty4HttpRequestBodyStreamwill register close listener to channel, but never deregister. This PR removes listener whenLastHttpContentis sent downstream to handler. Tested with debugger. Netty does not expose registered listeners.Another minor change. Currently I
setAutoRead(true)when stream receiveLastHttpContentdespite downstream state and current queueing. This PRsetAutoRead(true)whenLastHttpContentis sent to downstream, not on reception.