Ensure incremental bulk setting is set atomically#112479
Merged
Tim-Brooks merged 4 commits intoelastic:partial-rest-requestsfrom Sep 5, 2024
Merged
Ensure incremental bulk setting is set atomically#112479Tim-Brooks merged 4 commits intoelastic:partial-rest-requestsfrom
Tim-Brooks merged 4 commits intoelastic:partial-rest-requestsfrom
Conversation
Currently the rest.incremental_bulk is read in two different places. This means that it will be employed in two steps introducing unpredictable behavior. This commit ensures that it is only read in a single place.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
…emental_atomic_flag
henningandersen
approved these changes
Sep 5, 2024
server/src/main/java/org/elasticsearch/action/bulk/IncrementalBulkService.java
Show resolved
Hide resolved
|
|
||
| public static final Setting<Boolean> INCREMENTAL_BULK = boolSetting( | ||
| "rest.incremental_bulk", | ||
| true, |
Contributor
There was a problem hiding this comment.
I'd probably want to flip this before merge to main? Unless we are confident in having the feature enabled without a rollout plan. Can be a follow-up.
Contributor
Author
There was a problem hiding this comment.
I will add a ticket and make it a blocker for merge into main.
Tim-Brooks
added a commit
that referenced
this pull request
Sep 17, 2024
Currently the rest.incremental_bulk is read in two different places. This means that it will be employed in two steps introducing unpredictable behavior. This commit ensures that it is only read in a single place.
Tim-Brooks
added a commit
that referenced
this pull request
Sep 18, 2024
Currently the rest.incremental_bulk is read in two different places. This means that it will be employed in two steps introducing unpredictable behavior. This commit ensures that it is only read in a single place.
Tim-Brooks
added a commit
that referenced
this pull request
Sep 18, 2024
Currently the rest.incremental_bulk is read in two different places. This means that it will be employed in two steps introducing unpredictable behavior. This commit ensures that it is only read in a single place.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Sep 19, 2024
Currently the rest.incremental_bulk is read in two different places. This means that it will be employed in two steps introducing unpredictable behavior. This commit ensures that it is only read in a single place.
Tim-Brooks
added a commit
that referenced
this pull request
Sep 20, 2024
This commit back ports all of the work introduced in: #113044 * #111438 - 5e1f655 * #111865 - 478baf1 * #112179 - 1b77421 * #112227 - cbcbc34 * #112267 - c00768a * #112154 - a03fb12 * #112479 - 95b42a7 * #112608 - ce2d648 * #112629 - 0d55dc6 * #112767 - 2dbbd7d * #112724 - 58e3a39 * dce8a0b * #112974 - 92daeeb * 529d349 * #113161 - e3424bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the rest.incremental_bulk is read in two different places.
This means that it will be employed in two steps introducing
unpredictable behavior. This commit ensures that it is only read in a
single place.