Skip to content

Reduce autoread changes in header validator#112608

Merged
Tim-Brooks merged 6 commits intoelastic:partial-rest-requestsfrom
Tim-Brooks:more_conservative_auto_read_in_validator
Sep 6, 2024
Merged

Reduce autoread changes in header validator#112608
Tim-Brooks merged 6 commits intoelastic:partial-rest-requestsfrom
Tim-Brooks:more_conservative_auto_read_in_validator

Conversation

@Tim-Brooks
Copy link
Copy Markdown
Contributor

The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.

The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.
@Tim-Brooks Tim-Brooks added >non-issue :Distributed/Network Http and internode communication implementations v8.16.0 labels Sep 6, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Sep 6, 2024
Copy link
Copy Markdown
Contributor

@mhl-b mhl-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tim-Brooks Tim-Brooks requested review from a team as code owners September 6, 2024 17:23
@mark-vieira mark-vieira removed the request for review from a team September 6, 2024 17:44
@Tim-Brooks Tim-Brooks merged commit af9bfe7 into elastic:partial-rest-requests Sep 6, 2024
Tim-Brooks added a commit that referenced this pull request Sep 17, 2024
The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.
Tim-Brooks added a commit that referenced this pull request Sep 18, 2024
The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.
Tim-Brooks added a commit that referenced this pull request Sep 18, 2024
The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this pull request Sep 19, 2024
The header validator is very aggressive about adjusting autoread on the
belief it is the only place where autoread is tweaked. However, with
stream backpressure, we should only change it when we are starting or
finishing header validation.
Tim-Brooks added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Network Http and internode communication implementations >non-issue Team:Distributed Meta label for distributed team. v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants