[ESQL] Clean up UNSUPPORTED type blocks#111648
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Aug 6, 2024
Merged
[ESQL] Clean up UNSUPPORTED type blocks#111648elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Aug 6, 2024
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 7, 2024
* upstream/main: (132 commits) Fix compile after several merges Update docs with new behavior on skip conditions (elastic#111640) Skip on any instance of node or version features being present (elastic#111268) Skip on any node capability being present (elastic#111585) [DOCS] Publishes Anthropic inference service docs. (elastic#111619) Introduce `ChunkedZipResponse` (elastic#109820) [Gradle] fix esql compile cacheability (elastic#111651) Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testTermsQuery elastic#111666 Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testMatchAllQuery elastic#111664 Mute org.elasticsearch.xpack.esql.analysis.VerifierTests testMatchCommand elastic#111661 Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithMultipleMatches {default} elastic#111660 Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommand {default} elastic#111659 Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithWhereClause {default} elastic#111658 LogsDB qa tests - add specific matcher for source (elastic#111568) ESQL: Move `randomLiteral` (elastic#111647) [ESQL] Clean up UNSUPPORTED type blocks (elastic#111648) ESQL: Remove the `NESTED` DataType (elastic#111495) ESQL: Move more out of esql-core (elastic#111604) Improve MvPSeriesWeightedSum edge case and add more tests (elastic#111552) Add link to flood-stage watermark exception message (elastic#111315) ... # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 7, 2024
I hit an NPE while testing against creating unsupported blocks. We were trying to create a bytes ref of `null`, which isn't valid. I've changed the test code to instead use append null. While investigating that, I found `UnsupportedValuesSource`, which seems vestigial. The only uses I found for it were references to the `UNSUPPORTED_OUTPUT` constant, which is just `null`, one of which was the erroneous `BytesRef` constructor I was trying to fix. I think in this case the named constant actually decreased the readability, as it was not obvious that we were passing in a null there (although Intellij did flag it with a warning). At any rate, I've inlined the two other uses of that constant and removed the otherwise-unused class.
mhl-b
pushed a commit
that referenced
this pull request
Aug 8, 2024
I hit an NPE while testing against creating unsupported blocks. We were trying to create a bytes ref of `null`, which isn't valid. I've changed the test code to instead use append null. While investigating that, I found `UnsupportedValuesSource`, which seems vestigial. The only uses I found for it were references to the `UNSUPPORTED_OUTPUT` constant, which is just `null`, one of which was the erroneous `BytesRef` constructor I was trying to fix. I think in this case the named constant actually decreased the readability, as it was not obvious that we were passing in a null there (although Intellij did flag it with a warning). At any rate, I've inlined the two other uses of that constant and removed the otherwise-unused class.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
I hit an NPE while testing against creating unsupported blocks. We were trying to create a bytes ref of `null`, which isn't valid. I've changed the test code to instead use append null. While investigating that, I found `UnsupportedValuesSource`, which seems vestigial. The only uses I found for it were references to the `UNSUPPORTED_OUTPUT` constant, which is just `null`, one of which was the erroneous `BytesRef` constructor I was trying to fix. I think in this case the named constant actually decreased the readability, as it was not obvious that we were passing in a null there (although Intellij did flag it with a warning). At any rate, I've inlined the two other uses of that constant and removed the otherwise-unused class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit an NPE while testing against creating unsupported blocks. We were trying to create a bytes ref of
null, which isn't valid. I've changed the test code to instead use append null. While investigating that, I foundUnsupportedValuesSource, which seems vestigial. The only uses I found for it were references to theUNSUPPORTED_OUTPUTconstant, which is justnull, one of which was the erroneousBytesRefconstructor I was trying to fix. I think in this case the named constant actually decreased the readability, as it was not obvious that we were passing in a null there (although Intellij did flag it with a warning). At any rate, I've inlined the two other uses of that constant and removed the otherwise-unused class.