Skip to content

Add a note to the docs about differences between skip and requires#111640

Merged
thecoop merged 3 commits intoelastic:mainfrom
thecoop:rest-test-skip-docs
Aug 7, 2024
Merged

Add a note to the docs about differences between skip and requires#111640
thecoop merged 3 commits intoelastic:mainfrom
thecoop:rest-test-skip-docs

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Aug 6, 2024

Update the docs for behaviour changes in #111585 and #111268

@thecoop thecoop added >docs General docs changes >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label labels Aug 6, 2024
@thecoop thecoop requested a review from a team August 6, 2024 14:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 6, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v8.16.0 labels Aug 6, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche
Copy link
Copy Markdown
Contributor

mosche commented Aug 7, 2024

This warning about skipping on capabilities in mixed cluster tests can be removed as well:
https://github.com/elastic/elasticsearch/pull/111640/files#diff-9178a836c7b454d766a3976d631c5723a604b4c1202679ad9934e39adf0174b0R149-R154

@thecoop thecoop merged commit b0c82f4 into elastic:main Aug 7, 2024
@thecoop thecoop deleted the rest-test-skip-docs branch August 7, 2024 09:38
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Aug 7, 2024
* upstream/main: (132 commits)
  Fix compile after several merges
  Update docs with new behavior on skip conditions (elastic#111640)
  Skip on any instance of node or version features being present (elastic#111268)
  Skip on any node capability being present (elastic#111585)
  [DOCS] Publishes Anthropic inference service docs. (elastic#111619)
  Introduce `ChunkedZipResponse` (elastic#109820)
  [Gradle] fix esql compile cacheability (elastic#111651)
  Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testTermsQuery elastic#111666
  Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testMatchAllQuery elastic#111664
  Mute org.elasticsearch.xpack.esql.analysis.VerifierTests testMatchCommand elastic#111661
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithMultipleMatches {default} elastic#111660
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommand {default} elastic#111659
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithWhereClause {default} elastic#111658
  LogsDB qa tests - add specific matcher for source (elastic#111568)
  ESQL: Move `randomLiteral` (elastic#111647)
  [ESQL] Clean up UNSUPPORTED type blocks (elastic#111648)
  ESQL: Remove the `NESTED` DataType (elastic#111495)
  ESQL: Move more out of esql-core (elastic#111604)
  Improve MvPSeriesWeightedSum edge case and add more tests (elastic#111552)
  Add link to flood-stage watermark exception message (elastic#111315)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Aug 7, 2024
elastic#111585 and elastic#111268 change the behavior to skip on any node having the feature/capability, not all nodes
mhl-b pushed a commit that referenced this pull request Aug 8, 2024
#111585 and #111268 change the behavior to skip on any node having the feature/capability, not all nodes
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
elastic#111585 and elastic#111268 change the behavior to skip on any node having the feature/capability, not all nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team >test Issues or PRs that are addressing/adding tests v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants