Skip to content

Skip on any instance of node or version features being present#111268

Merged
thecoop merged 3 commits intoelastic:mainfrom
thecoop:skip-any-cluster-features
Aug 7, 2024
Merged

Skip on any instance of node or version features being present#111268
thecoop merged 3 commits intoelastic:mainfrom
thecoop:skip-any-cluster-features

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Jul 25, 2024

If any node has a specific feature or version feature specified in a skip YAML test, then skip that test, instead of only skipping if all nodes have that feature

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests WIP :Core/Infra/Core Core issues without another label labels Jul 25, 2024
@thecoop thecoop requested review from ldematte and mosche July 25, 2024 08:53
Copy link
Copy Markdown
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thecoop 🎉 LGTM

@thecoop thecoop removed the WIP label Jul 25, 2024
@thecoop thecoop requested a review from a team July 25, 2024 15:38
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 25, 2024
@thecoop thecoop merged commit ff04511 into elastic:main Aug 7, 2024
thecoop added a commit that referenced this pull request Aug 7, 2024
#111585 and #111268 change the behavior to skip on any node having the feature/capability, not all nodes
@thecoop thecoop deleted the skip-any-cluster-features branch August 7, 2024 09:38
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Aug 7, 2024
* upstream/main: (132 commits)
  Fix compile after several merges
  Update docs with new behavior on skip conditions (elastic#111640)
  Skip on any instance of node or version features being present (elastic#111268)
  Skip on any node capability being present (elastic#111585)
  [DOCS] Publishes Anthropic inference service docs. (elastic#111619)
  Introduce `ChunkedZipResponse` (elastic#109820)
  [Gradle] fix esql compile cacheability (elastic#111651)
  Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testTermsQuery elastic#111666
  Mute org.elasticsearch.datastreams.logsdb.qa.StandardVersusLogsIndexModeChallengeRestIT testMatchAllQuery elastic#111664
  Mute org.elasticsearch.xpack.esql.analysis.VerifierTests testMatchCommand elastic#111661
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithMultipleMatches {default} elastic#111660
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommand {default} elastic#111659
  Mute org.elasticsearch.xpack.esql.optimizer.LocalPhysicalPlanOptimizerTests testMatchCommandWithWhereClause {default} elastic#111658
  LogsDB qa tests - add specific matcher for source (elastic#111568)
  ESQL: Move `randomLiteral` (elastic#111647)
  [ESQL] Clean up UNSUPPORTED type blocks (elastic#111648)
  ESQL: Remove the `NESTED` DataType (elastic#111495)
  ESQL: Move more out of esql-core (elastic#111604)
  Improve MvPSeriesWeightedSum edge case and add more tests (elastic#111552)
  Add link to flood-stage watermark exception message (elastic#111315)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Aug 7, 2024
…ic#111268)

Update features skip behavior to skip on any node having the feature, not all nodes
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Aug 7, 2024
elastic#111585 and elastic#111268 change the behavior to skip on any node having the feature/capability, not all nodes
mhl-b pushed a commit that referenced this pull request Aug 8, 2024
Update features skip behavior to skip on any node having the feature, not all nodes
mhl-b pushed a commit that referenced this pull request Aug 8, 2024
#111585 and #111268 change the behavior to skip on any node having the feature/capability, not all nodes
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
…ic#111268)

Update features skip behavior to skip on any node having the feature, not all nodes
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
elastic#111585 and elastic#111268 change the behavior to skip on any node having the feature/capability, not all nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants