Skip to content

Deprecate Telemetry / APM legacy settings in favor of the new telemetry.* settings#104908

Merged
mosche merged 4 commits intoelastic:mainfrom
mosche:apm_deprecate_legacy_settings
Apr 11, 2024
Merged

Deprecate Telemetry / APM legacy settings in favor of the new telemetry.* settings#104908
mosche merged 4 commits intoelastic:mainfrom
mosche:apm_deprecate_legacy_settings

Conversation

@mosche
Copy link
Copy Markdown
Contributor

@mosche mosche commented Jan 30, 2024

#104345 and #104376 introduced new, less ambiguous telemetry / APM settings names.
This PR deprecates the old tracing.apm.* legacy settings in favor of telemetry[.tracing].*.

@mosche mosche added >non-issue :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team labels Jan 30, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, approved pending breaking change review

@elastic elastic deleted a comment from mosche Jan 30, 2024
@mosche mosche marked this pull request as draft January 31, 2024 08:20
@mosche
Copy link
Copy Markdown
Contributor Author

mosche commented Apr 5, 2024

After closing #106997 as invalid, I'm wrapping up this.
The deprecation / breaking change is approved (2481).

@mosche mosche requested a review from pgomulka April 5, 2024 11:38
@mosche mosche marked this pull request as ready for review April 5, 2024 11:38
@mosche
Copy link
Copy Markdown
Contributor Author

mosche commented Apr 10, 2024

kind ping @pgomulka, could you have a look

Copy link
Copy Markdown
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit 7ee5c73 into elastic:main Apr 11, 2024
@mosche mosche deleted the apm_deprecate_legacy_settings branch April 11, 2024 06:44
craigtaverner pushed a commit to craigtaverner/elasticsearch that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants