New APM settings using telemetry. prefix deprecate ambiguous tracing.apm. settings.#104376
Conversation
…ng.apm." settings.
APM settings are renamed from "tracing.apm.{name}" to "telemetry.tracing.{name}" for tracing related settings. General APM settings are renamed to "telemetry.{name}". The old settings are deprecated and applied as fallback.
(ES-7542)
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
modules/apm/src/main/java/org/elasticsearch/telemetry/apm/internal/APMAgentSettings.java
Show resolved
Hide resolved
pgomulka
left a comment
There was a problem hiding this comment.
LGTM,
however we need to confirm the deprecation with BCC
| ), | ||
| OperatorDynamic, | ||
| NodeScope, | ||
| DeprecatedWarning |
There was a problem hiding this comment.
by marking a setting with DeprecatedWarning we are indicating that this will be removed. This is simialar to my comment on the affix settings. #104345 (comment)
as per @stu-elastic 's comment it would have to be consulted with Breaking changes committee
I think it is worth rising now. We don't necessarily need to plan to remove it in near future, but we want to suggest users not to use it (with just a warning - as you have used).
There was a problem hiding this comment.
Is there any docs on the deprecation process @pgomulka? I'm not sure what needs to be done next.
There was a problem hiding this comment.
@pgomulka I've removed all deprecation warnings here. I'm going to move those into an independent PR to wrap up this part.
There was a problem hiding this comment.
sounds good. feel free to merge
...ribution/tools/server-cli/src/test/java/org/elasticsearch/server/cli/APMJvmOptionsTests.java
Outdated
Show resolved
Hide resolved
stu-elastic
left a comment
There was a problem hiding this comment.
lgtm once randomness is removed
APM settings are renamed from
tracing.apm.{name}totelemetry.tracing.{name}for tracing related settings. General APM settings are renamed totelemetry.{name}. The old settings are deprecated and applied as fallback.(ES-7542)