Add Alias fallbacks for simple & list settings#106997
Closed
mosche wants to merge 4 commits intoelastic:mainfrom
Closed
Add Alias fallbacks for simple & list settings#106997mosche wants to merge 4 commits intoelastic:mainfrom
mosche wants to merge 4 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @mosche, I've created a changelog YAML for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on the previous attempt #106061 and implements alias support for simple and list settings on top of fallbacks. The
aliasbehavior of a fallback is enabled by addingProperty.Alias.Fallback settings (as is today) are not well-suited when migrating a setting from one key to another. The problem is that update consumers are not properly triggered if both the old (fallback) and new setting are present causing changes to be silently ignored if the old version is used.
Alias fallbacks behave similar to fallbacks with some few differences:
Setting.exitsdoesn't consider fallbacks, but considers aliases which impacts the behavior ofSetting.getusing primary and secondary settings.