feat(partition): enable grooves in all group layers#666
Merged
monfera merged 4 commits intoelastic:masterfrom May 19, 2020
Merged
feat(partition): enable grooves in all group layers#666monfera merged 4 commits intoelastic:masterfrom
monfera merged 4 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 72.97% 72.91% -0.06%
==========================================
Files 266 266
Lines 8634 8641 +7
Branches 1698 1625 -73
==========================================
Hits 6301 6301
- Misses 2294 2301 +7
Partials 39 39
Continue to review full report at Codecov.
|
markov00
reviewed
May 19, 2020
Collaborator
markov00
left a comment
There was a problem hiding this comment.
I'm not sure, but I remember that before this change it was possible to "hide" the grooves (like it was before the grooves were available).
I've tried to return empty or null labels/values or 0 font size but it doesn't seems to work anymore
|
|
||
| function topGrooveAccessor(topGroovePx: Pixels) { | ||
| return (n: ArrayEntry) => (entryValue(n).depth === 1 ? topGroovePx : grooveAccessor(n)); | ||
| return (n: ArrayEntry) => (entryValue(n).depth > 0 ? topGroovePx : grooveAccessor(n)); |
nickofthyme
approved these changes
May 19, 2020
Contributor
Author
|
@markov00 the Multi-color Treemap story has it hidden, via specifying |
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 266 266
Lines 8678 8678
Branches 1710 1710
=======================================
Hits 6301 6301
Misses 2338 2338
Partials 39 39
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
May 28, 2020
# [19.4.0](v19.3.0...v19.4.0) (2020-05-28) ### Bug Fixes * **partition:** consider legendMaxDepth on legend size ([#654](#654)) ([9429dcf](9429dcf)), closes [#639](#639) ### Features * **partition:** enable grooves in all group layers ([#666](#666)) ([f5b4767](f5b4767)) * **partition:** linked text overflow avoidance ([#670](#670)) ([b6e5911](b6e5911)), closes [#633](#633) * **partition:** monotonic font size scaling ([#681](#681)) ([ea2489b](ea2489b)), closes [#661](#661) * **tooltip:** improve positioning with popperjs ([#651](#651)) ([6512950](6512950)), closes [#596](#596)
Collaborator
|
🎉 This PR is included in version 19.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.4.0](elastic/elastic-charts@v19.3.0...v19.4.0) (2020-05-28) ### Bug Fixes * **partition:** consider legendMaxDepth on legend size ([opensearch-project#654](elastic/elastic-charts#654)) ([20cc6ec](elastic/elastic-charts@20cc6ec)), closes [opensearch-project#639](elastic/elastic-charts#639) ### Features * **partition:** enable grooves in all group layers ([opensearch-project#666](elastic/elastic-charts#666)) ([b1bdfb3](elastic/elastic-charts@b1bdfb3)) * **partition:** linked text overflow avoidance ([opensearch-project#670](elastic/elastic-charts#670)) ([59617db](elastic/elastic-charts@59617db)), closes [opensearch-project#633](elastic/elastic-charts#633) * **partition:** monotonic font size scaling ([opensearch-project#681](elastic/elastic-charts#681)) ([d46767c](elastic/elastic-charts@d46767c)), closes [opensearch-project#661](elastic/elastic-charts#661) * **tooltip:** improve positioning with popperjs ([opensearch-project#651](elastic/elastic-charts#651)) ([61d1d9a](elastic/elastic-charts@61d1d9a)), closes [opensearch-project#596](elastic/elastic-charts#596)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables grooves, therefore makes multilayer group texts feasible. Requires careful tuning of color, font sizes etc. as it gets quite busy, depending on data.
Checklist
Delete any items that are not applicable to this PR.
src/index.ts(and stories only import from../srcexcept for test data & storybook)