Skip to content

Commit b6e5911

Browse files
monferamonfera
authored
feat(partition): linked text overflow avoidance (#670)
Truncates linked labels to avoid horizontal protrusion of text. Removes linked labels that have no remaining label text due to the truncation, or independent of this, which would protrude vertically. Fix #633
1 parent a79e899 commit b6e5911

14 files changed

Lines changed: 124 additions & 28 deletions

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-bold-link-value-visually-looks-correct-1-snap.png‎

-1.18 KB
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-clockwise-no-special-visually-looks-correct-1-snap.png‎

-110 Bytes
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-counter-clockwise-special-visually-looks-correct-1-snap.png‎

-681 Bytes
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-linked-labels-only-visually-looks-correct-1-snap.png‎

-1.46 KB
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-most-basic-visually-looks-correct-1-snap.png‎

-1.35 KB
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-negative-visually-looks-correct-1-snap.png‎

-422 Bytes
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-not-a-number-visually-looks-correct-1-snap.png‎

-422 Bytes
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-some-zero-value-slice-visually-looks-correct-1-snap.png‎

-17.2 KB
Loading

‎integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-sunburst-value-formatted-with-categorical-color-palette-visually-looks-correct-1-snap.png‎

-819 Bytes
Loading

‎src/chart_types/partition_chart/layout/types/geometry_types.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,30 +31,40 @@ export type Radius = Cartesian;
3131
export type Radian = Cartesian; // we measure angle in radians, and there's unity between radians and cartesian distances which is the whole point of radians; this is also relevant as we use small-angle approximations
3232
export type Distance = Cartesian;
3333

34+
/* @internal */
3435
export interface PointObject {
3536
x: Coordinate;
3637
y: Coordinate;
3738
}
3839

40+
/* @internal */
3941
export type PointTuple = [Coordinate, Coordinate];
4042

43+
/* @internal */
44+
export type PointTuples = [PointTuple, ...PointTuple[]]; // at least one point
45+
46+
/* @internal */
4147
export class Circline {
4248
x: Coordinate = NaN;
4349
y: Coordinate = NaN;
4450
r: Radius = NaN;
4551
}
4652

53+
/* @internal */
4754
export interface CirclinePredicate extends Circline {
4855
inside: boolean;
4956
}
5057

58+
/* @internal */
5159
export interface CirclineArc extends Circline {
5260
from: Radian;
5361
to: Radian;
5462
}
5563

64+
/* @internal */
5665
type CirclinePredicateSet = CirclinePredicate[];
5766

67+
/* @internal */
5868
export type RingSector = CirclinePredicateSet;
5969

6070
export type TimeMs = number;

0 commit comments

Comments
 (0)