fix(partition): consider legendMaxDepth on legend size#654
Merged
markov00 merged 7 commits intoelastic:masterfrom May 26, 2020
Merged
fix(partition): consider legendMaxDepth on legend size#654markov00 merged 7 commits intoelastic:masterfrom
markov00 merged 7 commits intoelastic:masterfrom
Conversation
On partition chart we should compute the legend size only for the elements actually rendered, so everything below the legendMaxDepth if used fix elastic#639
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 72.60% 72.63% +0.02%
==========================================
Files 266 266
Lines 8678 8686 +8
Branches 1710 1696 -14
==========================================
+ Hits 6301 6309 +8
Misses 2338 2338
Partials 39 39
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
May 26, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM. Tested legend in multiple partition stories, issue fixed.
src/chart_types/partition_chart/state/selectors/get_legend_items_labels.ts
Outdated
Show resolved
Hide resolved
markov00
pushed a commit
that referenced
this pull request
May 28, 2020
# [19.4.0](v19.3.0...v19.4.0) (2020-05-28) ### Bug Fixes * **partition:** consider legendMaxDepth on legend size ([#654](#654)) ([9429dcf](9429dcf)), closes [#639](#639) ### Features * **partition:** enable grooves in all group layers ([#666](#666)) ([f5b4767](f5b4767)) * **partition:** linked text overflow avoidance ([#670](#670)) ([b6e5911](b6e5911)), closes [#633](#633) * **partition:** monotonic font size scaling ([#681](#681)) ([ea2489b](ea2489b)), closes [#661](#661) * **tooltip:** improve positioning with popperjs ([#651](#651)) ([6512950](6512950)), closes [#596](#596)
Collaborator
Author
|
🎉 This PR is included in version 19.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.4.0](elastic/elastic-charts@v19.3.0...v19.4.0) (2020-05-28) ### Bug Fixes * **partition:** consider legendMaxDepth on legend size ([opensearch-project#654](elastic/elastic-charts#654)) ([20cc6ec](elastic/elastic-charts@20cc6ec)), closes [opensearch-project#639](elastic/elastic-charts#639) ### Features * **partition:** enable grooves in all group layers ([opensearch-project#666](elastic/elastic-charts#666)) ([b1bdfb3](elastic/elastic-charts@b1bdfb3)) * **partition:** linked text overflow avoidance ([opensearch-project#670](elastic/elastic-charts#670)) ([59617db](elastic/elastic-charts@59617db)), closes [opensearch-project#633](elastic/elastic-charts#633) * **partition:** monotonic font size scaling ([opensearch-project#681](elastic/elastic-charts#681)) ([d46767c](elastic/elastic-charts@d46767c)), closes [opensearch-project#661](elastic/elastic-charts#661) * **tooltip:** improve positioning with popperjs ([opensearch-project#651](elastic/elastic-charts#651)) ([61d1d9a](elastic/elastic-charts@61d1d9a)), closes [opensearch-project#596](elastic/elastic-charts#596)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix the legend size computation for Partition charts taking in consideration the
legendMaxDepthvalue if present.fix #639
Checklist
Delete any items that are not applicable to this PR.