fix(axis): scale tick labels to fix text truncation on chrome#38
Merged
emmacunningham merged 4 commits intoelastic:masterfrom Feb 6, 2019
Merged
fix(axis): scale tick labels to fix text truncation on chrome#38emmacunningham merged 4 commits intoelastic:masterfrom
emmacunningham merged 4 commits intoelastic:masterfrom
Conversation
markov00
reviewed
Feb 5, 2019
markov00
approved these changes
Feb 6, 2019
Collaborator
markov00
left a comment
There was a problem hiding this comment.
LGTM. Tested on chrome and the problem is now solved.
markov00
pushed a commit
that referenced
this pull request
Feb 7, 2019
# 1.0.0 (2019-02-07) ### Bug Fixes * reflect specs ids on legend items when using single series ([8b39f15](8b39f15)) * **axis:** add axisTitleHeight to axis increments ([#29](#29)) ([e34f0ae](e34f0ae)), closes [#26](#26) * **axis:** fix horizontal title positioning to account for title padding ([08d1f83](08d1f83)) * **axis:** scale tick labels to fix text truncation on chrome ([#38](#38)) ([99c2332](99c2332)), closes [#18](#18) * **axis:** use titleFontSize for debug rect for horizontal axis title ([#17](#17)) ([af4aa58](af4aa58)), closes [#11](#11) * **dimensions:** use chart top padding in computation of chart height ([42585f7](42585f7)), closes [#13](#13) * **x_domain:** fix x value asc sorting using numbers ([26b33ff](26b33ff)) ### Features * add tickLabelRotation and showGridLines features ([#7](#7)) ([47f118b](47f118b)) * **axis:** draw grid lines separately from axis tick and customize style with config ([#8](#8)) ([ab7e974](ab7e974))
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# 1.0.0 (2019-02-07) ### Bug Fixes * reflect specs ids on legend items when using single series ([ecbe4c6](elastic/elastic-charts@ecbe4c6)) * **axis:** add axisTitleHeight to axis increments ([opensearch-project#29](elastic/elastic-charts#29)) ([1f4b48b](elastic/elastic-charts@1f4b48b)), closes [opensearch-project#26](elastic/elastic-charts#26) * **axis:** fix horizontal title positioning to account for title padding ([d167af6](elastic/elastic-charts@d167af6)) * **axis:** scale tick labels to fix text truncation on chrome ([opensearch-project#38](elastic/elastic-charts#38)) ([3e6a400](elastic/elastic-charts@3e6a400)), closes [opensearch-project#18](elastic/elastic-charts#18) * **axis:** use titleFontSize for debug rect for horizontal axis title ([opensearch-project#17](elastic/elastic-charts#17)) ([7e5f7d6](elastic/elastic-charts@7e5f7d6)), closes [#11](elastic/elastic-charts#11) * **dimensions:** use chart top padding in computation of chart height ([4bc5ac8](elastic/elastic-charts@4bc5ac8)), closes [#13](elastic/elastic-charts#13) * **x_domain:** fix x value asc sorting using numbers ([f64c6aa](elastic/elastic-charts@f64c6aa)) ### Features * add tickLabelRotation and showGridLines features ([#7](elastic/elastic-charts#7)) ([ced76ce](elastic/elastic-charts@ced76ce)) * **axis:** draw grid lines separately from axis tick and customize style with config ([#8](elastic/elastic-charts#8)) ([411950b](elastic/elastic-charts@411950b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18
tl;dr the
measureTextfunction returns very different results from browser to browser and also possibly within the same browser as well, especially with very small font sizes. We employ a strategy that scales up the font, measures the text size, then divides the result with the scaling factor to get a more accurate measurement of the text width. Labels should now render fully in Chrome (the labels remain the same in Firefox):