fix(axis): fix horizontal title positioning to account for title padding

emmacunningham · markov00 · commit 08d1f8352446 · 2019-01-31T14:50:36.000+01:00
12
diff --git a/src/components/react_canvas/axis.tsx b/src/components/react_canvas/axis.tsx
@@ -177,7 +177,7 @@ export class Axis extends React.PureComponent<AxisProps> {
       return null;
     }
     if (isHorizontal(position)) {
-      return this.renderOriziontalAxisTitle();
+      return this.renderHorizontalAxisTitle();
     }
     return this.renderVerticalAxisTitle();
   }
@@ -229,13 +229,13 @@ export class Axis extends React.PureComponent<AxisProps> {
       </Group>
     );
   }
-  private renderOriziontalAxisTitle() {
+  private renderHorizontalAxisTitle() {
     const {
       axisPosition: { width, height },
       axisSpec: { title, position, tickSize, tickPadding },
       axisTicksDimensions: { maxLabelBboxHeight },
       chartTheme: {
-        axes: { titleFontSize },
+        axes: { titleFontSize, titlePadding },
       },
       debug,
     } = this.props;
@@ -244,7 +244,10 @@ export class Axis extends React.PureComponent<AxisProps> {
       return;
     }
 
-    const top = position === Position.Top ? -maxLabelBboxHeight : maxLabelBboxHeight + tickPadding + tickSize;
+    const top = position === Position.Top ?
+      -maxLabelBboxHeight - titlePadding :
+      maxLabelBboxHeight + tickPadding + tickSize + titlePadding;
+
     const left = 0;
     return (
       <Group>
