fix(x_domain): fix x value asc sorting using numbers

markov00 · markov00 · commit 26b33ff92263 · 2019-02-05T22:01:32.000+01:00
diff --git a/src/lib/series/domains/x_domain.ts b/src/lib/series/domains/x_domain.ts
@@ -1,4 +1,4 @@
-import { identity } from '../../utils/commons';
+import { compareByValueAsc, identity } from '../../utils/commons';
 import { computeContinuousDataDomain, computeOrdinalDataDomain } from '../../utils/domain';
 import { ScaleType } from '../../utils/scales/scales';
 import { BasicSeriesSpec } from '../specs';
@@ -49,14 +49,17 @@ export function mergeXDomain(
  * to display a bar chart in a linear scale.
  */
 export function findMinInterval(xValues: number[]): number | null {
-  const sortedValues = xValues.slice().sort();
+  if (xValues.length === 1) {
+    return 1;
+  }
+  const sortedValues = xValues.slice().sort(compareByValueAsc);
   const sortedValuesLength = sortedValues.length - 1;
   let i;
   let minInterval = null;
   for (i = 0; i < sortedValuesLength; i++) {
     const current = sortedValues[i];
     const next = sortedValues[i + 1];
-    const interval = next - current;
+    const interval = Math.abs(next - current);
     if (minInterval === null) {
       minInterval = interval;
     } else {
diff --git a/src/lib/utils/commons.ts b/src/lib/utils/commons.ts
@@ -1,3 +1,7 @@
 export function identity<T>(value: T): T {
   return value;
 }
+
+export function compareByValueAsc(firstEl: number, secondEl: number): number {
+  return firstEl - secondEl;
+}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,7 @@`
`1`	`1`	`export function identity<T>(value: T): T {`
`2`	`2`	`return value;`
`3`	`3`	`}`
	`4`	`+`
	`5`	`+export function compareByValueAsc(firstEl: number, secondEl: number): number {`
	`6`	`+ return firstEl - secondEl;`
	`7`	`+}`