fix(barSeries): error rendering bars with negative log scale#2407
Merged
nickofthyme merged 21 commits intoelastic:mainfrom May 7, 2024
Merged
fix(barSeries): error rendering bars with negative log scale#2407nickofthyme merged 21 commits intoelastic:mainfrom
nickofthyme merged 21 commits intoelastic:mainfrom
Conversation
Collaborator
Author
|
buildkite update screenshots |
- remove upsidedown height logic, use negative height and handle render accordingly. - add range helper utils to check for values in first and last half of given range.
- This comes from the change to use the shared `getY1ScaledValueFn` that adds a little extra for elastic#1053. - The chrome bug causing elastic#1053 has now been fixed, so removing this code.
- also fixes min height for banded bars that cross `0`
nickofthyme
commented
Apr 26, 2024
Collaborator
Author
nickofthyme
left a comment
There was a problem hiding this comment.
Just leaving comments to explain specific code changes.
...ages/charts/src/chart_types/xy_chart/state/selectors/get_tooltip_values_highlighted_geoms.ts
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/renderer/dom/highlighter.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
buildkite update screenshots |
Collaborator
Author
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
May 20, 2024
# [65.0.0](v64.1.0...v65.0.0) (2024-05-20) ### Bug Fixes * **barSeries:** error rendering bars with negative log scale ([#2407](#2407)) ([4ab6d8f](4ab6d8f)) * **deps:** update dependency @elastic/eui to ^93.5.1 ([#2375](#2375)) ([35ed956](35ed956)) * **deps:** update dependency @elastic/eui to ^93.5.2 ([#2386](#2386)) ([e26c6dd](e26c6dd)) * **deps:** update dependency @elastic/eui to ^93.6.0 ([#2393](#2393)) ([40f2b7b](40f2b7b)) * **deps:** update dependency @elastic/eui to ^94.3.0 ([#2424](#2424)) ([cff5181](cff5181)) * **deps:** update dependency @elastic/eui to v94 ([#2409](#2409)) ([67c814f](67c814f)) * **deps:** update dependency @playwright/test to ^1.43.0 ([#2388](#2388)) ([42f86d7](42f86d7)) * **deps:** update dependency @playwright/test to ^1.43.1 ([#2413](#2413)) ([79b1c7f](79b1c7f)) * **deps:** update dependency json-schema-to-typescript to v14 ([#2414](#2414)) ([785f635](785f635)) * **deps:** update dependency json-schema-to-typescript to v14.0.4 ([#2421](#2421)) ([790170a](790170a)) * **legend:** custom legend covered by background ([#2366](#2366)) ([5b9ffac](5b9ffac)) ### Features * add support for start day of week on MLT axis ([#2362](#2362)) ([3aac1f0](3aac1f0)) * **Legend:** change click on item behaviour ([#2427](#2427)) ([b1c72df](b1c72df)) * **legend:** change click on item behaviour ([#2431](#2431)) ([b03bdd0](b03bdd0)) * **legend:** Improve interactions legend labels ([#2418](#2418)) ([384baac](384baac)) * **legend:** select legend statistic value ([#2355](#2355)) ([a602838](a602838)) * **metric:** support array of values ([#2428](#2428)) ([e448bd7](e448bd7)) ### Reverts * **legend:** change click on item behaviour ([#2429](#2429)) ([cc438a1](cc438a1)), closes [#2427](#2427) ### BREAKING CHANGES * **legend:** The legend modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR mainly fixes the rendering of bars on a negative log scale. Also fixes the tooltip for banded bar charts.
In addition this PR fixes some other issues including
getY1ScaledValueFnandgetY0ScaledValueFnfunctions I just removed this logic to avoid checking.Details
The bar geometry logic was using custom logic to handle the scaled
y1andy0values, this was imperfect. This same issue was not present withAreaSeriesas we had already addressed it. Using the same logic from area geometries fixed the issue.Secondly, while testing the above fix for banded
BarSeries, I noticed that the tooltip never showed thelowerbound item on the tooltip. This again only an issue for bar charts. The issue is that unlike theAreaSeriestheBarSeriesgeometry is a single geometry for the upper and lower whereas the area is 2 points. So simply adding they0geometry to theindexedGeometryMapsolved the issue, see bed2b45.Issues
fix #2406, fix #2408, fix #607
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)