feat: add support for start day of week on MLT axis#2362
Merged
nickofthyme merged 13 commits intoelastic:mainfrom Mar 27, 2024
Merged
feat: add support for start day of week on MLT axis#2362nickofthyme merged 13 commits intoelastic:mainfrom
nickofthyme merged 13 commits intoelastic:mainfrom
Conversation
Collaborator
Author
|
buildkite update screenshots |
Collaborator
Author
|
buildkite update screenshots |
Collaborator
Author
|
@markov00 I updated the code based on our discussion to move the option to the |
markov00
reviewed
Mar 19, 2024
packages/charts/src/chart_types/xy_chart/axes/timeslip/chrono/chrono_luxon/chrono_luxon.ts
Outdated
Show resolved
Hide resolved
e2e/screenshots/all.test.ts-snapshots/baselines/test-cases/start-day-of-week-chrome-linux.png
Show resolved
Hide resolved
Collaborator
Author
|
buildkite update screenshots |
Collaborator
Author
|
buildkite update screenshots |
markov00
approved these changes
Mar 27, 2024
nickofthyme
pushed a commit
that referenced
this pull request
May 20, 2024
# [65.0.0](v64.1.0...v65.0.0) (2024-05-20) ### Bug Fixes * **barSeries:** error rendering bars with negative log scale ([#2407](#2407)) ([4ab6d8f](4ab6d8f)) * **deps:** update dependency @elastic/eui to ^93.5.1 ([#2375](#2375)) ([35ed956](35ed956)) * **deps:** update dependency @elastic/eui to ^93.5.2 ([#2386](#2386)) ([e26c6dd](e26c6dd)) * **deps:** update dependency @elastic/eui to ^93.6.0 ([#2393](#2393)) ([40f2b7b](40f2b7b)) * **deps:** update dependency @elastic/eui to ^94.3.0 ([#2424](#2424)) ([cff5181](cff5181)) * **deps:** update dependency @elastic/eui to v94 ([#2409](#2409)) ([67c814f](67c814f)) * **deps:** update dependency @playwright/test to ^1.43.0 ([#2388](#2388)) ([42f86d7](42f86d7)) * **deps:** update dependency @playwright/test to ^1.43.1 ([#2413](#2413)) ([79b1c7f](79b1c7f)) * **deps:** update dependency json-schema-to-typescript to v14 ([#2414](#2414)) ([785f635](785f635)) * **deps:** update dependency json-schema-to-typescript to v14.0.4 ([#2421](#2421)) ([790170a](790170a)) * **legend:** custom legend covered by background ([#2366](#2366)) ([5b9ffac](5b9ffac)) ### Features * add support for start day of week on MLT axis ([#2362](#2362)) ([3aac1f0](3aac1f0)) * **Legend:** change click on item behaviour ([#2427](#2427)) ([b1c72df](b1c72df)) * **legend:** change click on item behaviour ([#2431](#2431)) ([b03bdd0](b03bdd0)) * **legend:** Improve interactions legend labels ([#2418](#2418)) ([384baac](384baac)) * **legend:** select legend statistic value ([#2355](#2355)) ([a602838](a602838)) * **metric:** support array of values ([#2428](#2428)) ([e448bd7](e448bd7)) ### Reverts * **legend:** change click on item behaviour ([#2429](#2429)) ([cc438a1](cc438a1)), closes [#2427](#2427) ### BREAKING CHANGES * **legend:** The legend modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to set the start day of the week for multilayer time axis via
Settings.dow. See story example for demo below ⬇️Details
The
Settings.dowoption expects an integer between1and7according to ISO 8601Issues
closes #2361
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)