Skip to content

fix(legend): custom legend covered by background#2366

Merged
nickofthyme merged 2 commits intoelastic:mainfrom
nickofthyme:fix-legend-z-index
Mar 18, 2024
Merged

fix(legend): custom legend covered by background#2366
nickofthyme merged 2 commits intoelastic:mainfrom
nickofthyme:fix-legend-z-index

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Mar 16, 2024

Summary

Fixes an issue causing the legend to be placed behind the .echChartBackground element.

Details

The .echChartBackground element had no z-index applied which causes any custom legend to be covered by the background.

Issues

fix #2363

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@nickofthyme nickofthyme added :legend Legend related issue :all Applies to all chart types labels Mar 16, 2024
@nickofthyme nickofthyme marked this pull request as ready for review March 18, 2024 16:56
@nickofthyme nickofthyme requested a review from markov00 March 18, 2024 16:58
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks ok for me

@nickofthyme nickofthyme merged commit 5b9ffac into elastic:main Mar 18, 2024
@nickofthyme nickofthyme deleted the fix-legend-z-index branch March 18, 2024 18:14
nickofthyme pushed a commit that referenced this pull request May 20, 2024
# [65.0.0](v64.1.0...v65.0.0) (2024-05-20)

### Bug Fixes

* **barSeries:** error rendering bars with negative log scale ([#2407](#2407)) ([4ab6d8f](4ab6d8f))
* **deps:** update dependency @elastic/eui to ^93.5.1 ([#2375](#2375)) ([35ed956](35ed956))
* **deps:** update dependency @elastic/eui to ^93.5.2 ([#2386](#2386)) ([e26c6dd](e26c6dd))
* **deps:** update dependency @elastic/eui to ^93.6.0 ([#2393](#2393)) ([40f2b7b](40f2b7b))
* **deps:** update dependency @elastic/eui to ^94.3.0 ([#2424](#2424)) ([cff5181](cff5181))
* **deps:** update dependency @elastic/eui to v94 ([#2409](#2409)) ([67c814f](67c814f))
* **deps:** update dependency @playwright/test to ^1.43.0 ([#2388](#2388)) ([42f86d7](42f86d7))
* **deps:** update dependency @playwright/test to ^1.43.1 ([#2413](#2413)) ([79b1c7f](79b1c7f))
* **deps:** update dependency json-schema-to-typescript to v14 ([#2414](#2414)) ([785f635](785f635))
* **deps:** update dependency json-schema-to-typescript to v14.0.4 ([#2421](#2421)) ([790170a](790170a))
* **legend:** custom legend covered by background ([#2366](#2366)) ([5b9ffac](5b9ffac))

### Features

* add support for start day of week on MLT axis ([#2362](#2362)) ([3aac1f0](3aac1f0))
* **Legend:** change click on item behaviour ([#2427](#2427)) ([b1c72df](b1c72df))
* **legend:** change click on item behaviour ([#2431](#2431)) ([b03bdd0](b03bdd0))
* **legend:** Improve interactions legend labels ([#2418](#2418)) ([384baac](384baac))
* **legend:** select legend statistic value ([#2355](#2355)) ([a602838](a602838))
* **metric:** support array of values ([#2428](#2428)) ([e448bd7](e448bd7))

### Reverts

* **legend:** change click on item behaviour ([#2429](#2429)) ([cc438a1](cc438a1)), closes [#2427](#2427)

### BREAKING CHANGES

* **legend:** The legend modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:all Applies to all chart types :legend Legend related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom legend doesn't take mouse events?

2 participants