Fix sample config in log rotation docs by jsoriano · Pull Request #33306 · elastic/beats

jsoriano · 2022-10-11T10:06:00Z

Troubleshooting guide for logs rotation contains a sample configuration with enabled: false. I guess this configuration shouldn't be disabled. Enable it, and migrate it from log input to filestream.

These are the sample configurations in https://www.elastic.co/guide/en/beats/filebeat/8.4/file-log-rotation.html#log-rotate-example

mergify · 2022-10-11T10:06:36Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jsoriano? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2022-10-11T10:07:56Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine · 2022-10-11T10:14:19Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-10-11T10:06:16.443+0000
Duration: 8 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dedemorton

Oh boy. Not sure how that happened, but your change LGTM. :-)

~~Looks like you need to update the branch before merging tho.~~ nevermind...looks like it's OK

(cherry picked from commit 277776a)

(cherry picked from commit 277776a) Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

* Fix errors for non-synth capable instances (#33310) Fixes #32694 by making sure we use the lightweight wrapper code always when monitors cannot be initialized. This also fixes an unrelated bug, where errors attached to non-summary events would not be indexed. * [Automation] Update elastic stack version to 8.6.0-5a8d757d for testing (#33323) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * add pid awareness to file locking (#33169) * add pid awareness to file locking * cleanup, logic for handling restarts with the same PID * add zombie-state awareness * fix file naming * add retry for unlock * was confused by unlock code, fix, cleanup * update notice * fix race with file creation, update deps * clean up tests, spelling * hack for cgo * add lic headers * notice * try to fix windows issues * fix typos * small fixes * use exclusive locks * remove feature to start with a specially named pidfile * clean up some error handling, fix test cleanup * forgot changelog * Fix sample config in log rotation docs (#33306) * Add banner to deprecate functionbeat (#33297) * fix unchecked stream_id * packetbeat/protos/dns: clean up package (#33286) * avoid magic numbers * fix hashableDNSTuple size and offsets * avoid use of String and Error methods in formatted print calls * remove redundant conversions * quieten linter * use plugin-owned logp.Logger * update elastic-agent-libs * Revert "fix unchecked stream_id" This reverts commit 26ef6da. * [Automation] Update elastic stack version to 8.6.0-40086bc7 for testing (#33339) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

(cherry picked from commit 277776a) Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

* Update Metricbeat, Filebeat, libbeat with elastic-agent V2 support (#32673) * basic framework * continued tinkering * move away from ast code, use a struct * get metricbeat working, starting on filebeat * add notice update * add basic config register * move over processors to individual beats * remove comments * start to integrate V2 client changes * finishing touches * lint * cleanup merge * remove V1 controller * stil tinkering with linter * still fixing linter * plz linter * fmt x-pack files * notice update * fix output test * refactor stop functions, refactor tests, some misc cleanup * fix client version string * add devguide * linter * expand filebeat test * cleanup test * fix docs, add tests, debuggin * add signal handler * fix mutex issue in register * Fix osquerybeat configuration for V2 * clean up component registration * spelling * remove workaround for filebeat types * try to fix filebeat tests * add nil checks, fix test, fix unit stop * continue tinkering with nil type checks * add test for missing config datastreams, clean up nil handling * change nil protections, use getter methods * fix config access in output code Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co> * V2 packetbeat support (#33041) * first attempt at auditbeat support * add license header * initial packetbeat support * fix bad branch * cleanup * typo in comment * clean up, move around files * add new processors to streams * First pass at auditbeat support (#33026) * first attempt at auditbeat support * add license header * cleanup * move files around * Add heartbeat support for V2 (#33157) * add v2 config * fix name * fix doc * fix go.mod * fix unchecked stream_id * fix unchecked stream_id (#33335) * Update elastic-agent-libs for output panic fix (#33336) * Fix errors for non-synth capable instances (#33310) Fixes #32694 by making sure we use the lightweight wrapper code always when monitors cannot be initialized. This also fixes an unrelated bug, where errors attached to non-summary events would not be indexed. * [Automation] Update elastic stack version to 8.6.0-5a8d757d for testing (#33323) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> * add pid awareness to file locking (#33169) * add pid awareness to file locking * cleanup, logic for handling restarts with the same PID * add zombie-state awareness * fix file naming * add retry for unlock * was confused by unlock code, fix, cleanup * update notice * fix race with file creation, update deps * clean up tests, spelling * hack for cgo * add lic headers * notice * try to fix windows issues * fix typos * small fixes * use exclusive locks * remove feature to start with a specially named pidfile * clean up some error handling, fix test cleanup * forgot changelog * Fix sample config in log rotation docs (#33306) * Add banner to deprecate functionbeat (#33297) * fix unchecked stream_id * packetbeat/protos/dns: clean up package (#33286) * avoid magic numbers * fix hashableDNSTuple size and offsets * avoid use of String and Error methods in formatted print calls * remove redundant conversions * quieten linter * use plugin-owned logp.Logger * update elastic-agent-libs * Revert "fix unchecked stream_id" This reverts commit 26ef6da. * [Automation] Update elastic stack version to 8.6.0-40086bc7 for testing (#33339) Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> * update elastic-agent-client (#33552) Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co> Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com> Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>

Fix sample config in log rotation docs

a3e54ed

jsoriano requested review from a team October 11, 2022 10:06

jsoriano self-assigned this Oct 11, 2022

jsoriano requested review from cmacknz and leehinman and removed request for a team October 11, 2022 10:06

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 11, 2022

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 11, 2022

dedemorton approved these changes Oct 11, 2022

View reviewed changes

jsoriano merged commit 277776a into elastic:main Oct 12, 2022

mergify bot mentioned this pull request Oct 12, 2022

[7.17](backport #33306) Fix sample config in log rotation docs #33331

Merged

mergify bot pushed a commit that referenced this pull request Oct 12, 2022

Fix sample config in log rotation docs (#33306)

9e75931

(cherry picked from commit 277776a)

mergify bot pushed a commit that referenced this pull request Oct 12, 2022

Fix sample config in log rotation docs (#33306)

1332429

(cherry picked from commit 277776a)

mergify bot mentioned this pull request Oct 12, 2022

[8.5](backport #33306) Fix sample config in log rotation docs #33332

Merged

rdner pushed a commit that referenced this pull request Oct 13, 2022

Fix sample config in log rotation docs (#33306) (#33331)

d8e78ba

(cherry picked from commit 277776a) Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

jsoriano added a commit that referenced this pull request Oct 14, 2022

Fix sample config in log rotation docs (#33306) (#33332)

0a61346

(cherry picked from commit 277776a) Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

Fix sample config in log rotation docs (#33306)

b294104

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sample config in log rotation docs#33306

Fix sample config in log rotation docs#33306
jsoriano merged 1 commit intoelastic:mainfrom
jsoriano:enable-log-docs

jsoriano commented Oct 11, 2022 •

edited

Loading

Uh oh!

mergify bot commented Oct 11, 2022

Uh oh!

elasticmachine commented Oct 11, 2022

Uh oh!

elasticmachine commented Oct 11, 2022

Build stats

Uh oh!

dedemorton left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jsoriano commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Oct 11, 2022

Uh oh!

elasticmachine commented Oct 11, 2022

Uh oh!

elasticmachine commented Oct 11, 2022

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

Uh oh!

dedemorton left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jsoriano commented Oct 11, 2022 •

edited

Loading

dedemorton left a comment •

edited

Loading