Osquerybeat: Return the query result count with the action response#28576
Merged
aleksmaus merged 2 commits intoelastic:masterfrom Oct 21, 2021
Merged
Osquerybeat: Return the query result count with the action response#28576aleksmaus merged 2 commits intoelastic:masterfrom
aleksmaus merged 2 commits intoelastic:masterfrom
Conversation
lykkin
reviewed
Oct 20, 2021
|
|
||
| a.log.Debugf("Completed query in: %v", time.Since(start)) | ||
|
|
||
| a.publisher.Publish(index, ac.ID, responseID, hits, ac.ECSMapping, req["data"]) |
Contributor
There was a problem hiding this comment.
can this have a partial failure on Publish? if so, how are failures to publish surfaced in the publisher?
Contributor
Author
There was a problem hiding this comment.
this API doesn't return errors. publishing is handled by libbeat, including retries and batching. the errors are surfaces through the logs
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
lykkin
approved these changes
Oct 20, 2021
Contributor
Author
|
/test |
aleksmaus
added a commit
that referenced
this pull request
Oct 22, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2021
…urnalbeat-ci * upstream/master: (49 commits) [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589) fix: use declarative style for complete variant of the elastic-agent (elastic#28526) x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609) docs: Update `api_key` example on elasticsearch output (elastic#28606) chore: add build scripts to CODEOWNERS (elastic#28615) Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622) Add note about changes to regexp package in Golang (elastic#28616) CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612) Osquerybeat: Fix extenstion unable to start on windows (elastic#28598) Osquerybeat: Return the query result count with the action response (elastic#28576) Agent: Allow custom response properties in the action response (elastic#28575) [Heartbeat] Only setuid in elastic-agent image (elastic#28577) Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530) CI: refactor the run e2e build (elastic#28502) Use fsnotify with long windows name-safe changes (elastic#28517) Remove unneeded mergify config backport: Add 7.16 branch (elastic#28560) Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533) Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434) [Heartbeat] Make run_once syntax a boolean (elastic#28548) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Return the query result count with the action response
This would allow osquery UI to detect when all the results are received and stop showing the progress indicator.
Related issues
Screenshots
Confirmed mapping is created:
Confirmed the data is indexed and searchable with osquerybeat that now provides the number of rows returned by the query:
