Fix formatting of mapStateJSON and layerListJSON in dashboard assets#28530
Merged
kvch merged 9 commits intoelastic:masterfrom Oct 21, 2021
Merged
Fix formatting of mapStateJSON and layerListJSON in dashboard assets#28530kvch merged 9 commits intoelastic:masterfrom
mapStateJSON and layerListJSON in dashboard assets#28530kvch merged 9 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
michalpristas
approved these changes
Oct 19, 2021
metricbeat/tests/system/test_base.py
Outdated
|
|
||
| @unittest.skipUnless(INTEGRATION_TESTS, "integration test") | ||
| @pytest.mark.timeout(180, func_only=True) | ||
| @pytest.mark.timeout(5*60, func_only=True) |
Contributor
There was a problem hiding this comment.
math doesn't add up :-)
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
approved these changes
Oct 19, 2021
Member
jsoriano
left a comment
There was a problem hiding this comment.
👍 looks good, adding a suggestion about sharing the code to test dashboards along beats.
Member
Btw, this is a very good one 👍 |
LeeDr
reviewed
Oct 19, 2021
| services: | ||
| elasticsearch: | ||
| image: docker.elastic.co/elasticsearch/elasticsearch:7.14.0 | ||
| image: docker.elastic.co/elasticsearch/elasticsearch:7.15.0 |
There was a problem hiding this comment.
why wouldn't this be 8.0.0 for the tests on master branch?
Contributor
Author
There was a problem hiding this comment.
latest.yml contains the latests releases. We use the environment in snapshot.yml for the latest snapshots of 8.0.0 on master.
Contributor
❕ Build Aborted
Expand to view the summary
Build stats
Test errors
Expand to view the tests failures
|
jsoriano
approved these changes
Oct 20, 2021
Contributor
Author
|
jenkins run tests |
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2021
…urnalbeat-ci * upstream/master: (49 commits) [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589) fix: use declarative style for complete variant of the elastic-agent (elastic#28526) x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609) docs: Update `api_key` example on elasticsearch output (elastic#28606) chore: add build scripts to CODEOWNERS (elastic#28615) Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622) Add note about changes to regexp package in Golang (elastic#28616) CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612) Osquerybeat: Fix extenstion unable to start on windows (elastic#28598) Osquerybeat: Return the query result count with the action response (elastic#28576) Agent: Allow custom response properties in the action response (elastic#28575) [Heartbeat] Only setuid in elastic-agent image (elastic#28577) Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530) CI: refactor the run e2e build (elastic#28502) Use fsnotify with long windows name-safe changes (elastic#28517) Remove unneeded mergify config backport: Add 7.16 branch (elastic#28560) Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533) Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434) [Heartbeat] Make run_once syntax a boolean (elastic#28548) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces more transformations to dashboards that are loaded to Kibana to avoid parsing errors. For the sake of developers we save everything as JSON, but some of the values have to be loaded back to Kibana as strings. A few field conversions were missing, now they are added.
I have added dashboard loading tests to Metricbeat, Filebeat and Packetbeat to catch such errors before they are released/other teams discover it.
Why is it important?
Without this some dashboards cannot be loaded.
Checklist
~~- [ ] I have commented my code, particularly in hard-to-understand areas~`
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #27988