Use fsnotify with long windows name-safe changes#28517
Merged
efd6 merged 1 commit intoelastic:masterfrom Oct 21, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ab765b8 to
112610c
Compare
adriansr
approved these changes
Oct 19, 2021
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM, but this needs a changelog entry.
112610c to
a7ca000
Compare
a7ca000 to
0c93401
Compare
Contributor
Author
|
/test |
2 similar comments
Member
|
/test |
Contributor
Author
|
/test |
Member
|
The e2e tests are being looked at for the moment, to make the build pass. |
Contributor
|
I think it's safe to merge this without waiting for the flaky e2e tests to be fixed. Also I suggest backporting to 7.15 too. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit cd8fc07) # Conflicts: # NOTICE.txt # go.mod # go.sum
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
(cherry picked from commit cd8fc07)
efd6
added a commit
that referenced
this pull request
Oct 26, 2021
(cherry picked from commit cd8fc07)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2021
…urnalbeat-ci * upstream/master: (49 commits) [CI]: use the downstream packaging pipeline for branches/tags (elastic#28589) fix: use declarative style for complete variant of the elastic-agent (elastic#28526) x-pack/auditbeat/tracing: fix regexp for kprobe description line (elastic#28609) docs: Update `api_key` example on elasticsearch output (elastic#28606) chore: add build scripts to CODEOWNERS (elastic#28615) Osquerybeat: Fix host_processes missing cmdline arguments (elastic#28622) Add note about changes to regexp package in Golang (elastic#28616) CI: nightly/weekly builds for 7.x targeting 7.16 instead (elastic#28612) Osquerybeat: Fix extenstion unable to start on windows (elastic#28598) Osquerybeat: Return the query result count with the action response (elastic#28576) Agent: Allow custom response properties in the action response (elastic#28575) [Heartbeat] Only setuid in elastic-agent image (elastic#28577) Fix formatting of `mapStateJSON` and `layerListJSON` in dashboard assets (elastic#28530) CI: refactor the run e2e build (elastic#28502) Use fsnotify with long windows name-safe changes (elastic#28517) Remove unneeded mergify config backport: Add 7.16 branch (elastic#28560) Add proxy_url support to threatintel module's malwarebazaar fileset (elastic#28533) Osquerybeat: Implement host_users, host_groups, host_processes tables as a part of our osquery_extension. (elastic#28434) [Heartbeat] Make run_once syntax a boolean (elastic#28548) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change makes use of changes to adriansr/fsnotify that prevent runtime oob crash when events relate to windows files with long (>260) filenames.
Why is it important?
This fixes a bug, #25334.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Instructions for reproducing the bug fixed by this are provided at the original issue #25334.
Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A