Rename dashboards according to module.yml files for master#27749
Rename dashboards according to module.yml files for master#27749kvch merged 5 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Pinging @elastic/agent (Team:Agent) |
094868f to
2cf229a
Compare
jsoriano
left a comment
There was a problem hiding this comment.
Files are renamed without changing the ids of the dashboards they contain, so they will have the wrong id if exported again. Should we also modify the ids in the dashboard files? Or modify the module.yml files instead? I think the id in the files, the name of the files and the references should be consistent.
Should we have some test or check to validate that the files references there exist?
Btw, another possible approach... what is the module.yml file used for during dashboards setup? Could we remove this file and just load all the resources available?
jsoriano
left a comment
There was a problem hiding this comment.
Discussed offline, it LGTM, we can decide the future of the module.yml files later.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
(cherry picked from commit 669102d)
* master: (39 commits) [Heartbeat] Move JSON tests from python->go (elastic#27816) docs: simplify permissions for Dockerfile COPY (elastic#27754) Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789) [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774) warn log entry and no validation failure when both queue_url and buck… (elastic#27612) libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178) [Heartbeat] Add httpcommon options to ZipURL (elastic#27699) Add a header round tripper option to httpcommon (elastic#27509) [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779) Rename dashboards according to module.yml files for master (elastic#27749) Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726) Accept syslog dates with leading 0 (elastic#27775) [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727) [Filebeat] Threatintel compatibility updates (elastic#27323) Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707) [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491) Fix flakyness of TestFilestreamEmptyLine (elastic#27705) [Filebeat] kafka v2 using parsers (elastic#27335) Update Kafka version parsing / supported range (elastic#27720) Update Sarama to 1.29.1 (elastic#27717) ...
What does this PR do?
This PR renames existing dashboards according to the config in
module.ymlfiles. Also, it fixes the outdated dashboard of the Netflow input.Why is it important?
The dashboard of the Netflow input was outdated. Thus, setup has failed.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.