Refactor vagrantfile, add scripts for provisioning with docker/kind#27726
Merged
fearful-symmetry merged 8 commits intoelastic:masterfrom Sep 7, 2021
Merged
Refactor vagrantfile, add scripts for provisioning with docker/kind#27726fearful-symmetry merged 8 commits intoelastic:masterfrom
fearful-symmetry merged 8 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
Author
|
/test |
jsoriano
approved these changes
Sep 7, 2021
Member
jsoriano
left a comment
There was a problem hiding this comment.
Awesome refactor. Love to see the provision scripts moved to their own files. Thanks!
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Sep 9, 2021
* master: (39 commits) [Heartbeat] Move JSON tests from python->go (elastic#27816) docs: simplify permissions for Dockerfile COPY (elastic#27754) Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789) [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774) warn log entry and no validation failure when both queue_url and buck… (elastic#27612) libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178) [Heartbeat] Add httpcommon options to ZipURL (elastic#27699) Add a header round tripper option to httpcommon (elastic#27509) [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779) Rename dashboards according to module.yml files for master (elastic#27749) Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726) Accept syslog dates with leading 0 (elastic#27775) [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727) [Filebeat] Threatintel compatibility updates (elastic#27323) Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707) [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491) Fix flakyness of TestFilestreamEmptyLine (elastic#27705) [Filebeat] kafka v2 using parsers (elastic#27335) Update Kafka version parsing / supported range (elastic#27720) Update Sarama to 1.29.1 (elastic#27717) ...
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…lastic#27726) * clean up vagrant scripts * major refactor, partway done * fix ordering issues * finish refactor * fix shell calls * example docker invocation * fix example command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This was undertaken as part of my need to test cgroups V2 support on a variety of platforms and docker versions. The current vagrantfile is an aboslute mess, so this is a total refactor that changes how the platforms are listed, moves the provisioning scripts, and adds provisioning options for
dockerandkindIdeally, we'd have some testing automation that would run arbitrary tests inside the boxes/containers, but...that falls outside the scope of this, and I have a bad enough habit of making feature-creep PRs.
Why is it important?
This cleans up a very ugly, outdated vagrant file and adds code so we can test docker on various platforms.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.