libbeat/cmd/instance: ensure test config file has appropriate permissions#27178
Merged
efd6 merged 1 commit intoelastic:masterfrom Sep 8, 2021
Merged
libbeat/cmd/instance: ensure test config file has appropriate permissions#27178efd6 merged 1 commit intoelastic:masterfrom
efd6 merged 1 commit intoelastic:masterfrom
Conversation
b013db5 to
d406358
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
|
/test |
mtojek
approved these changes
Aug 3, 2021
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
d406358 to
7d0b5c9
Compare
Contributor
|
/test |
…ions Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments.
7d0b5c9 to
cd1d8c0
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
…ions (#27178) Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments. (cherry picked from commit 627b7a8)
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
…ions (#27178) Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments. (cherry picked from commit 627b7a8) # Conflicts: # libbeat/cmd/instance/beat_test.go
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Sep 9, 2021
* master: (39 commits) [Heartbeat] Move JSON tests from python->go (elastic#27816) docs: simplify permissions for Dockerfile COPY (elastic#27754) Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789) [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774) warn log entry and no validation failure when both queue_url and buck… (elastic#27612) libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178) [Heartbeat] Add httpcommon options to ZipURL (elastic#27699) Add a header round tripper option to httpcommon (elastic#27509) [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779) Rename dashboards according to module.yml files for master (elastic#27749) Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726) Accept syslog dates with leading 0 (elastic#27775) [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727) [Filebeat] Threatintel compatibility updates (elastic#27323) Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707) [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491) Fix flakyness of TestFilestreamEmptyLine (elastic#27705) [Filebeat] kafka v2 using parsers (elastic#27335) Update Kafka version parsing / supported range (elastic#27720) Update Sarama to 1.29.1 (elastic#27717) ...
efd6
pushed a commit
that referenced
this pull request
Sep 9, 2021
…ions (#27178) (#27796) Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments. (cherry picked from commit 627b7a8) Co-authored-by: Dan Kortschak <dan@kortschak.io>
efd6
added a commit
that referenced
this pull request
Sep 13, 2021
… has appropriate permissions (#27797) * libbeat/cmd/instance: ensure test config file has appropriate permissions (#27178) Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments. (cherry picked from commit 627b7a8) # Conflicts: # libbeat/cmd/instance/beat_test.go * libbeat/cmd/instance: resolve backport conflict Co-authored-by: Dan Kortschak <dan@kortschak.io> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…ions (elastic#27178) Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail. This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is arguably a bug fix.
What does this PR do?
This change ensures that the test config is owner-exclusive write before running the test. It also adds checks to currently ineffective error assignments.
Why is it important?
Git does not store r/w permissions, instead depending on the host system's umask. On some systems the default umask is 0o002, meaning that the test config file is checked out with g+w permission, causing the test to fail.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Run
go testin github.com/elastic/beats/libbeat/cmd/instance.Related issues
No related issues.
Use cases
Screenshots
N/A
Logs
N/A