Add cloud.service.name to add_cloud_metadata#24993
Merged
andrewstucki merged 2 commits intoelastic:masterfrom Apr 9, 2021
Merged
Add cloud.service.name to add_cloud_metadata#24993andrewstucki merged 2 commits intoelastic:masterfrom
andrewstucki merged 2 commits intoelastic:masterfrom
Conversation
2 tasks
andrewkroh
approved these changes
Apr 8, 2021
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. For quick reference this PR uses these values:
| Provider | cloud.service.name |
|---|---|
| Alibaba | ECS |
| AWS | EC2 |
| Azure | Virtual Machines |
| Digital Ocean | Droplets |
| GCE | |
| OpenStack | Nova |
| Tencent | CVM |
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Add cloud.service.name to add_cloud_metadata * update changelog (cherry picked from commit 5bde9d0)
andrewstucki
pushed a commit
that referenced
this pull request
Apr 9, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 14, 2021
* upstream/master: (308 commits) [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945) mergify: add backport label (elastic#25050) Add pod.ip in k8s metadata (elastic#25037) [elastic-agent] Use fleet.url for container cmd (elastic#25026) disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034) Leverege leader election in agent k8s manifests (elastic#25016) libbeat/publisher/pipeline: expand monitoring (elastic#24700) libbeat: fix decode_json_fields config validation (elastic#24862) Remove make docs-preview instructions (elastic#25001) [Filebeat] Fix IPtables pipeline (elastic#24928) [DOCS] cd into correct directory before invoking mage. (elastic#17679) Add -buildmode=pie for supported platform (elastic#24964) Add agent's direcotry in k8s manifest generator (elastic#24987) [mergify] assign the original author (elastic#25007) Fix AWS module flaky tests (elastic#24852) [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967) Updated config to match defaults (elastic#25004) [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861) Add cloud.service.name to add_cloud_metadata (elastic#24993) [Ingest Manager] Expose processes and their metrics (elastic#24788) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the new ECS 1.9 field
cloud.service.nametoadd_cloud_metadata.I tried to use the names of each service we're retrieving metadata for as it exists in the majority of the literature. In some cases this means this uses shorthand names (i.e.
EC2) and, when shorthand isn't commonly in the cloud provider's docs (i.e. AWS), the full name is used (i.e.Virtual Machines).Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.