[DOCS] cd into correct directory before invoking mage.#17679
Merged
cavokz merged 2 commits intoelastic:masterfrom Apr 12, 2021
Merged
[DOCS] cd into correct directory before invoking mage.#17679cavokz merged 2 commits intoelastic:masterfrom
cavokz merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
cavokz
reviewed
Apr 6, 2021
Contributor
cavokz
left a comment
There was a problem hiding this comment.
This fix is needed and looks correct.
Contributor
|
jenkins run tests |
Contributor
|
This will probably need to be merged against master for CI to be happy. Is @bestpath-gb still around? |
Contributor
Author
|
@fearful-symmetry I am! Is there anything I can do to help with this? |
Contributor
|
@bestpath-gb can you merge against the upstream master? This branch is (I assume) very out of date. |
6a7d989 to
8f6a4d2
Compare
Contributor
Author
|
@fearful-symmetry I've rebased on latest upstream master. Let me know if there's anything else you need. |
Contributor
|
jenkins run tests |
Contributor
|
Ping @fearful-symmetry |
Contributor
|
@bestpath-gb sorry, one last thing, can you add a changelog entry to |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
e8df82a to
35ae081
Compare
Contributor
Author
|
@fearful-symmetry Changelog entry added. |
Contributor
|
jenkins run tests |
fearful-symmetry
approved these changes
Apr 12, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 14, 2021
* upstream/master: (308 commits) [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945) mergify: add backport label (elastic#25050) Add pod.ip in k8s metadata (elastic#25037) [elastic-agent] Use fleet.url for container cmd (elastic#25026) disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034) Leverege leader election in agent k8s manifests (elastic#25016) libbeat/publisher/pipeline: expand monitoring (elastic#24700) libbeat: fix decode_json_fields config validation (elastic#24862) Remove make docs-preview instructions (elastic#25001) [Filebeat] Fix IPtables pipeline (elastic#24928) [DOCS] cd into correct directory before invoking mage. (elastic#17679) Add -buildmode=pie for supported platform (elastic#24964) Add agent's direcotry in k8s manifest generator (elastic#24987) [mergify] assign the original author (elastic#25007) Fix AWS module flaky tests (elastic#24852) [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967) Updated config to match defaults (elastic#25004) [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861) Add cloud.service.name to add_cloud_metadata (elastic#24993) [Ingest Manager] Expose processes and their metrics (elastic#24788) ...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #14409
The docs for creating a new beat are currently wrong as they tell you to
cdinto your github home directory before callingmage GenerateCustomBeat. This gives the errorNo .go files marked with the mage build tag in this directory..This PR updates the docs so the reader will create their github home directory, then
cdinto the beats directory before running Mage.