libbeat/publisher/pipeline: expand monitoring#24700
Merged
axw merged 4 commits intoelastic:masterfrom Apr 13, 2021
Merged
Conversation
|
This pull request doesn't have a |
Expand monitoring to report: - pipeline.queue.max_events (queue capacity) - output.batch_size (e.g. ES bulk_max_size) - output.clients (e.g. number of ES hosts * workers) Queue capacity is recorded in stats rather than state so it can be used along with queue size to calculate saturation.
651cb6e to
e3e4c55
Compare
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
stuartnelson3
approved these changes
Mar 23, 2021
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
|
Pinging @elastic/agent (Team:Agent) |
urso
approved these changes
Apr 12, 2021
|
/test |
1 similar comment
Member
Author
|
/test |
Member
Author
|
Seems to be an issue with reporting Jenkins success, |
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* libbeat/publisher/pipeline: expand monitoring Expand monitoring to report: - pipeline.queue.max_events (queue capacity) - output.batch_size (e.g. ES bulk_max_size) - output.clients (e.g. number of ES hosts * workers) Queue capacity is recorded in stats rather than state so it can be used along with queue size to calculate saturation. * Move changelog entry to the right section (cherry picked from commit c24fb8e)
axw
added a commit
that referenced
this pull request
Apr 14, 2021
* libbeat/publisher/pipeline: expand monitoring Expand monitoring to report: - pipeline.queue.max_events (queue capacity) - output.batch_size (e.g. ES bulk_max_size) - output.clients (e.g. number of ES hosts * workers) Queue capacity is recorded in stats rather than state so it can be used along with queue size to calculate saturation. * Move changelog entry to the right section (cherry picked from commit c24fb8e) Co-authored-by: Andrew Wilkins <axw@elastic.co>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 14, 2021
* upstream/master: (308 commits) [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945) mergify: add backport label (elastic#25050) Add pod.ip in k8s metadata (elastic#25037) [elastic-agent] Use fleet.url for container cmd (elastic#25026) disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034) Leverege leader election in agent k8s manifests (elastic#25016) libbeat/publisher/pipeline: expand monitoring (elastic#24700) libbeat: fix decode_json_fields config validation (elastic#24862) Remove make docs-preview instructions (elastic#25001) [Filebeat] Fix IPtables pipeline (elastic#24928) [DOCS] cd into correct directory before invoking mage. (elastic#17679) Add -buildmode=pie for supported platform (elastic#24964) Add agent's direcotry in k8s manifest generator (elastic#24987) [mergify] assign the original author (elastic#25007) Fix AWS module flaky tests (elastic#24852) [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967) Updated config to match defaults (elastic#25004) [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861) Add cloud.service.name to add_cloud_metadata (elastic#24993) [Ingest Manager] Expose processes and their metrics (elastic#24788) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expand monitoring to report:
Queue capacity is recorded in stats rather than state so it can be used along with queue size to calculate saturation.
Note to reviewer, I introduced the
metricsObserverVarstype to avoid having awkward variable names just to avoid clashing with the method names.Why is it important?
In APM Server we recommend users tune
queue.mem.events,output.elasticsearch.bulk_max_size, andoutput.elasticsearch.workeraccording to their scale. It would be helpful to be able to observe the current value in effect.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run a beat with the Elasticsearch output and monitoring enabled, and check the values of
pipeline.queue.max_events,output.batch_size, andoutput.clientsmatch the configuration.Related issues
Closes #22215