Skip to content

[Metricbeat] Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Couchbase module#23287

Merged
jsoriano merged 5 commits intoelastic:masterfrom
krijohs:fix/couchbase_nodeinterestingstats_fields
Apr 1, 2021
Merged

[Metricbeat] Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Couchbase module#23287
jsoriano merged 5 commits intoelastic:masterfrom
krijohs:fix/couchbase_nodeinterestingstats_fields

Conversation

@krijohs
Copy link
Copy Markdown
Contributor

@krijohs krijohs commented Dec 25, 2020

Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Metricbeat Couchbase module (#21021)

What does this PR do?

The struct NodeInterestingStats in Metricbeat Couchbase module has the fields GetHits and Ops with a type of int64. But according the the issue (#21021) Couchbase returns a float for these fields. This pull requests will change those fields to float64.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run the Go tests in the node package. The values for the fields in data.json have been changed so a float is used as input and as expected value.

Related issues

Closes #21021

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 25, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 25, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: /test

  • Start Time: 2021-04-01T11:42:33.193+0000

  • Duration: 56 min 14 sec

  • Commit: ee45c13

Test stats 🧪

Test Results
Failed 0
Passed 8314
Skipped 2261
Total 10575

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8314
Skipped 2261
Total 10575

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Dec 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 26, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 26, 2020
@jsoriano jsoriano self-assigned this Mar 10, 2021
@jsoriano jsoriano self-requested a review March 10, 2021 10:13
@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 10, 2021

/test

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 17, 2021

/test

1 similar comment
@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Mar 17, 2021

/test

@jsoriano
Copy link
Copy Markdown
Member

jsoriano commented Apr 1, 2021

/test

@jsoriano jsoriano merged commit 38dac25 into elastic:master Apr 1, 2021
@jsoriano jsoriano mentioned this pull request Apr 1, 2021
Merged
6 tasks
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Apr 1, 2021
@krijohs @jsoriano
Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (
dd16e57 
elastic#23287)

They were defined as long, but they can be floats.

(cherry picked from commit 38dac25)
jsoriano added a commit that referenced this pull request Apr 1, 2021
@jsoriano @krijohs
Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (
78bc883 
#23287) (#24903)

They were defined as long, but they can be floats.

(cherry picked from commit 38dac25)

Co-authored-by: Kristoffer Johansson <51340510+krijohs@users.noreply.github.com>
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/mergify
c1238b8 
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@jsoriano jsoriano

Labels

Team:Integrations Label for the Integrations team v7.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metricbeat couchbase module fails to decode some fields

6 participants

@krijohs @elasticmachine @jsoriano @masci @andresrc @sayden