Skip to content

Cherry-pick #23287 to 7.x: [Metricbeat] Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Couchbase module#24903

Merged
jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano:backport_23287_7.x
Apr 1, 2021
Merged

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Apr 1, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23287 to 7.x branch. Original message:

Fix incorrect types of fields GetHits and Ops in NodeInterestingStats in Metricbeat Couchbase module (#21021)

What does this PR do?

The struct NodeInterestingStats in Metricbeat Couchbase module has the fields GetHits and Ops with a type of int64. But according the the issue (#21021) Couchbase returns a float for these fields. This pull requests will change those fields to float64.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run the Go tests in the node package. The values for the fields in data.json have been changed so a float is used as input and as expected value.

Related issues

Closes #21021

@krijohs @jsoriano
Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (
dd16e57 
elastic#23287)

They were defined as long, but they can be floats.

(cherry picked from commit 38dac25)
@jsoriano jsoriano added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Apr 1, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 1, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 1, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24903 opened

  • Start Time: 2021-04-01T14:13:03.978+0000

  • Duration: 50 min 19 sec

  • Commit: dd16e57

Test stats 🧪

Test Results
Failed 0
Passed 8311
Skipped 2264
Total 10575

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8311
Skipped 2264
Total 10575

@jsoriano jsoriano merged commit 78bc883 into elastic:7.x Apr 1, 2021
@jsoriano jsoriano deleted the backport_23287_7.x branch April 1, 2021 16:11
@zube zube bot removed the [zube]: Done label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoriano @elasticmachine @krijohs