Skip to content

Add support for Filestream input in elastic agent.#24820

Merged
ph merged 2 commits intoelastic:masterfrom
ph:elastic-agent/add-filestream-support
Apr 1, 2021
Merged

Add support for Filestream input in elastic agent.#24820
ph merged 2 commits intoelastic:masterfrom
ph:elastic-agent/add-filestream-support

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Mar 29, 2021 •
edited
Loading

Add support for the filestream input and regenerate the spec.

inputs:
 - type: filestream

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Add support for Filestream input in elastic agent.
10e8b78 
Add support for the filestream input and regenerate the spec.
```
inputs:
 - type: filestream
 ```
@ph ph added review Team:Elastic-Agent Label for the Agent team labels Mar 29, 2021
@ph ph requested review from kvch and urso March 29, 2021 18:09
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 29, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 29, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24820 event

  • Start Time: 2021-03-29T18:11:19.834+0000

  • Duration: 50 min 29 sec

  • Commit: 5877a51

Test stats 🧪

Test Results
Failed 0
Passed 6588
Skipped 16
Total 6604

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6588
Skipped 16
Total 6604

urso
urso reviewed Mar 29, 2021
View reviewed changes
x-pack/elastic-agent/spec/filebeat.yml
- udp
- unix
- winlog
- filestream
Copy link
Copy Markdown

@urso urso Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to expose it as filestream, or event/filestream via the mapper?

Copy link
Copy Markdown
Contributor Author

@ph ph Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I don't have a preference, event/filestream seems like a good idea? @mostlyjason @ruflin ?

Copy link
Copy Markdown
Contributor

@ruflin ruflin Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong preference on my end. Main downside of the prefix is that it is more cumbersome to type and harder to remember?

Copy link
Copy Markdown

@mostlyjason mostlyjason Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No preference for me

Copy link
Copy Markdown

@urso urso Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to maintain some kind of consistency for input names that are available via Agent. Unfortunately Filebeat input naming is not really consistent with the other Beats and even within Filebeat. As the input is not GA input I'm okay to keep it named filestream.

We already have event/log and the logfile inputs, each translating to logs. We will eventually replace logs with filestream. The filestream input is not 100% bc, that is we will also have to think about migration.

Copy link
Copy Markdown
Contributor Author

@ph ph Mar 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the proposal @urso, can you give a final review on this PR?

@ph ph merged commit 54f5cbf into elastic:master Apr 1, 2021
@ph ph mentioned this pull request Apr 1, 2021
Merged
6 tasks
@ph ph added the v7.13.0 label Apr 1, 2021
ph added a commit that referenced this pull request Apr 1, 2021
@ph
Add support for Filestream input in elastic agent. (#24820) (#24900)
11a3bc5 
* Add support for Filestream input in elastic agent.

Add support for the filestream input and regenerate the spec.
```
inputs:
 - type: filestream
 ```

(cherry picked from commit 54f5cbf)
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/mergify
c1238b8 
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin ruflin approved these changes

@kvch kvch Awaiting requested review from kvch

+2 more reviewers

@mostlyjason mostlyjason mostlyjason left review comments

@urso urso urso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review Team:Elastic-Agent Label for the Agent team v7.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ph @elasticmachine @urso @ruflin @mostlyjason