[Elastic Agent] Fix named pipe communication on Windows 7#21931
Merged
blakerouse merged 3 commits intoelastic:masterfrom Oct 19, 2020
Merged
[Elastic Agent] Fix named pipe communication on Windows 7#21931blakerouse merged 3 commits intoelastic:masterfrom
blakerouse merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
michalpristas
approved these changes
Oct 19, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Loooks like it takes some time for MS go-winio fixes to get in :(
LGTM
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Oct 19, 2020
) * Fix named pipes on Windows 7. * Add changelog fix notice. (cherry picked from commit 803ddca)
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Oct 19, 2020
) * Fix named pipes on Windows 7. * Add changelog fix notice. (cherry picked from commit 803ddca)
2 tasks
blakerouse
added a commit
that referenced
this pull request
Oct 20, 2020
blakerouse
added a commit
that referenced
this pull request
Oct 20, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 21, 2020
* upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) Azure storage metricset values not inside the metricset name (elastic#21845) fix diskio and memory bugs under windows (elastic#21992) Fix TestDockerStart flaky test (elastic#21681) filebeat: add SSL options to checkpoint module (elastic#19560) Stop storing stateless kubernetes keystores (elastic#21880) [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931) [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where on Windows 7 the first connection over a npipe would result in the client hanging and the server from never receiving the connection.
After digging deep into the Windows winio module I was able to determine it was an issue in the module and not in the Agent itself. microsoft/go-winio#173 Was reported as the issue, but has not been fixed in winio upstream. Use replace to github.com/bi-zone/go-winio fixes the issue as the change is committed in that repository and tagged.
Why is it important?
So installation of Elastic Agent works as expected and actions talking to the running daemon do not hang and block the executing installation.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues