filebeat: add SSL options to checkpoint module by hazcod · Pull Request #19560 · elastic/beats

hazcod · 2020-07-01T16:04:12Z

What does this PR do?

This adds a var.input type tls, which will use tcp + tls for mutual TLS authentication.

Why is it important?

Syslog udp is plaintext and does not guarantee CIA.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

#17682
CC @P1llus @adriansr @andrewstucki

elasticmachine · 2020-07-01T16:04:19Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2020-07-01T16:04:19Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

P1llus · 2020-07-01T16:21:45Z

Thanks for recreating the PR @hazcod . I know this is the second time around due to the issues with the last PR (including the merge from master most likely).

Will let you know how it goes, and also triggers a need to look a bit more deeper into where TLS should/should not be per default.

elasticmachine · 2020-07-01T16:23:00Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2020-07-01T16:38:43Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [marc-gr commented: jenkins run tests]
Start Time: 2020-10-19T14:13:16.438+0000
Duration: 65 min 41 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4474
Skipped	561
Total	5035

P1llus · 2020-07-01T16:45:46Z

jenkins test this please

hazcod · 2020-07-02T11:52:43Z

I ran a mage build in x-pack/filebeat/, but not sure what the command should be here.

P1llus · 2020-07-13T14:00:37Z

It asks you to run "mage fmt update" in the x-pack/filebeat folder @hazcod . I will see if I can add a review to it

hazcod · 2020-08-07T08:03:32Z

I've successfully ran mage fmt update @P1llus .

hazcod · 2020-08-24T07:30:21Z

Ping.

marc-gr · 2020-08-24T09:30:12Z

jenkins run tests

marc-gr

Thanks for your patience and for submitting this again ❤️ ! Please add a CHANGELOG entry, and besides this I left some comments. If you wish, we can take over from this point and push the required changes to your branch., or you can do them yourself, whatever works best for you.

x-pack/filebeat/module/checkpoint/firewall/config/firewall.yml

x-pack/filebeat/module/checkpoint/firewall/manifest.yml

x-pack/filebeat/tests/system/test_http_endpoint.py

hazcod · 2020-08-27T09:18:11Z

I've pushed the requested changes @marc-gr

marc-gr · 2020-08-27T11:13:13Z

jenkins run tests

hazcod · 2020-09-08T08:06:10Z

@marc-gr: I've updated the CHANGELOG entry.

marc-gr · 2020-09-08T08:07:09Z

jenkins run tests

marc-gr · 2020-09-08T09:00:19Z

jenkins run tests

hazcod · 2020-09-16T12:02:31Z

FYI @marc-gr / @P1llus you should have write access for this PR now too.

marc-gr · 2020-09-16T13:51:16Z

jenkins run tests

P1llus

LGMT, though should have another reviewer as well, to ensure there is nothing missing from the config entries, maybe compared to another one with TLS?

leehinman

LGTM

marc-gr · 2020-10-19T14:12:45Z

jenkins run tests

hazcod · 2020-10-19T15:32:43Z

Thank you all for the help!

* upstream/master: feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) Azure storage metricset values not inside the metricset name (elastic#21845) fix diskio and memory bugs under windows (elastic#21992) Fix TestDockerStart flaky test (elastic#21681) filebeat: add SSL options to checkpoint module (elastic#19560) Stop storing stateless kubernetes keystores (elastic#21880) [Elastic Agent] Fix named pipe communication on Windows 7 (elastic#21931) [Elastic Agent] Fix index for Agent monitoring to to elastic_agent. (elastic#21932)

* feat(firewall): add tls config * feat(firewall): add vars to manifest * chore(checkpoint): add tls to example * chore(checkpoint): run mage fmt update * cleanup(checkpoint): remove obsolete log_level * refactor(checkpoint): move to .ssl * chore(x-pack): revert ide fix * chore(changelog): add f5 asm ref * revert(changelog): remove f5 asm mod * chore(changelog): add checkpoint tls * chore: fix lint warnings * Undo some changes and move docs to checkpoint * Move changelog entry Co-authored-by: Marc Guasch <marc.guasch@elastic.co> (cherry picked from commit e29c3fa)

* feat(firewall): add tls config * feat(firewall): add vars to manifest * chore(checkpoint): add tls to example * chore(checkpoint): run mage fmt update * cleanup(checkpoint): remove obsolete log_level * refactor(checkpoint): move to .ssl * chore(x-pack): revert ide fix * chore(changelog): add f5 asm ref * revert(changelog): remove f5 asm mod * chore(changelog): add checkpoint tls * chore: fix lint warnings * Undo some changes and move docs to checkpoint * Move changelog entry Co-authored-by: Marc Guasch <marc.guasch@elastic.co> (cherry picked from commit e29c3fa) Co-authored-by: Niels Hofmans <hello@ironpeak.be>

hazcod added 2 commits July 1, 2020 17:23

feat(firewall): add tls config

898cd12

feat(firewall): add vars to manifest

72e5a44

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020

hazcod mentioned this pull request Jul 1, 2020

Filebeat: add TLS + pipeline options to checkpoint module #18116

Closed

6 tasks

P1llus added enhancement Team:SIEM labels Jul 1, 2020

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020

P1llus added Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label labels Jul 1, 2020

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020

P1llus added the review label Jul 1, 2020

chore(checkpoint): add tls to example

336e8e2

chore(checkpoint): run mage fmt update

4a0cf49

marc-gr requested changes Aug 26, 2020

View reviewed changes

hazcod added 3 commits August 27, 2020 11:03

cleanup(checkpoint): remove obsolete log_level

e5d28ab

refactor(checkpoint): move to .ssl

a8f1b06

chore(x-pack): revert ide fix

ae683e9

hazcod requested a review from marc-gr August 27, 2020 09:18

chore(changelog): add f5 asm ref

8b8c15e

hazcod added 2 commits September 8, 2020 10:09

revert(changelog): remove f5 asm mod

645ac38

chore(changelog): add checkpoint tls

09adc68

chore: fix lint warnings

4077c6e

marc-gr added 2 commits September 16, 2020 15:34

Merge remote-tracking branch 'upstream/master' into patch-2

d51420c

Undo some changes and move docs to checkpoint

d820d7a

marc-gr changed the title ~~filebeat: add TLS + pipeline options to checkpoint module~~ filebeat: add SSL options to checkpoint module Sep 16, 2020

P1llus reviewed Sep 16, 2020

View reviewed changes

marc-gr requested a review from a team September 17, 2020 07:22

marc-gr added 2 commits October 19, 2020 10:25

Merge remote-tracking branch 'upstream/master' into patch-2

ed0681a

Move changelog entry

4f9f621

leehinman approved these changes Oct 19, 2020

View reviewed changes

marc-gr approved these changes Oct 19, 2020

View reviewed changes

marc-gr merged commit e29c3fa into elastic:master Oct 19, 2020

marc-gr deleted the patch-2 branch October 19, 2020 15:19

marc-gr mentioned this pull request Oct 19, 2020

Cherry-pick #19560 to 7.x: filebeat: add SSL options to checkpoint module #21988

Merged

6 tasks

marc-gr added the v7.11.0 label Oct 19, 2020

andrewkroh mentioned this pull request Dec 1, 2020

Add syslog over TCP with TLS support to the Checkpoint module #19309

Closed

Conversation

hazcod commented Jul 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Related issues

Uh oh!

elasticmachine commented Jul 1, 2020

Uh oh!

elasticmachine commented Jul 1, 2020

Uh oh!

P1llus commented Jul 1, 2020

Uh oh!

elasticmachine commented Jul 1, 2020

Uh oh!

elasticmachine commented Jul 1, 2020 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Uh oh!

P1llus commented Jul 1, 2020

Uh oh!

hazcod commented Jul 2, 2020

Uh oh!

P1llus commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazcod commented Aug 7, 2020

Uh oh!

hazcod commented Aug 24, 2020

Uh oh!

marc-gr commented Aug 24, 2020

Uh oh!

marc-gr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hazcod commented Aug 27, 2020

Uh oh!

marc-gr commented Aug 27, 2020

Uh oh!

hazcod commented Sep 8, 2020

Uh oh!

marc-gr commented Sep 8, 2020

Uh oh!

marc-gr commented Sep 8, 2020

Uh oh!

hazcod commented Sep 16, 2020

Uh oh!

marc-gr commented Sep 16, 2020

Uh oh!

P1llus left a comment

Choose a reason for hiding this comment

Uh oh!

leehinman left a comment

Choose a reason for hiding this comment

Uh oh!

marc-gr commented Oct 19, 2020

Uh oh!

hazcod commented Oct 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hazcod commented Jul 1, 2020 •

edited

Loading

elasticmachine commented Jul 1, 2020 •

edited by jenkins-beats-ci bot

Loading

P1llus commented Jul 13, 2020 •

edited

Loading

marc-gr left a comment •

edited

Loading