libbeat/cmd/instance: report cgroup stats#21113
Merged
axw merged 3 commits intoelastic:masterfrom Sep 26, 2020
Merged
Conversation
Member
Author
|
@simitt I seem to recall you had something more elaborate in mind. Could you please take a look and let me know if you think more is needed? |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Member
Author
|
@ycombinator would you mind taking a quick look at this? Or else please suggest someone else to take a look. We'd like to get this in for 7.10, so we can get the Stack Monitoring UI updated to accurately reflect server performance when running in ESS/ECE. |
ycombinator
reviewed
Sep 24, 2020
ycombinator
approved these changes
Sep 24, 2020
1 task
axw
added a commit
to axw/beats
that referenced
this pull request
Sep 26, 2020
* libbeat/cmd/instance: report cgroup stats (cherry picked from commit b4c7a93)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
…peline-2.0 * upstream/master: libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (417 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (399 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (60 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Sep 28, 2020
Gosigar's cgroups GetStatsForProcesses can return a nil Stats pointer and no error when the ["blkio", "cpu", "cpuacct", "memory"] subsystems are on the root cgroup. Related elastic#21113
2 tasks
axw
pushed a commit
to axw/beats
that referenced
this pull request
Sep 29, 2020
Gosigar's cgroups GetStatsForProcesses can return a nil Stats pointer and no error when the ["blkio", "cpu", "cpuacct", "memory"] subsystems are on the root cgroup. Related elastic#21113
adriansr
added a commit
that referenced
this pull request
Sep 29, 2020
Gosigar's cgroups GetStatsForProcesses can return a nil Stats pointer and no error when the ["blkio", "cpu", "cpuacct", "memory"] subsystems are on the root cgroup. Related #21113
axw
added a commit
that referenced
this pull request
Sep 30, 2020
…21334) * libbeat/cmd/instance: report cgroup stats (#21113) * libbeat/cmd/instance: report cgroup stats (cherry picked from commit b4c7a93) * Fix panic in cgroups monitoring Gosigar's cgroups GetStatsForProcesses can return a nil Stats pointer and no error when the ["blkio", "cpu", "cpuacct", "memory"] subsystems are on the root cgroup. Related #21113 Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
axw
added a commit
to axw/apm-server
that referenced
this pull request
Sep 30, 2020
This was referenced Sep 30, 2020
axw
added a commit
to elastic/apm-server
that referenced
this pull request
Oct 2, 2020
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
axw
added a commit
to axw/apm-server
that referenced
this pull request
Oct 2, 2020
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
axw
added a commit
to elastic/apm-server
that referenced
this pull request
Oct 5, 2020
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
axw
added a commit
to elastic/elasticsearch
that referenced
this pull request
Dec 9, 2020
Add field mappings for the cgroups metrics added to beats monitoring in elastic/beats#21113, and required by elastic/kibana#79050.
axw
added a commit
to elastic/elasticsearch
that referenced
this pull request
Dec 9, 2020
Add field mappings for the cgroups metrics added to beats monitoring in elastic/beats#21113, and required by elastic/kibana#79050.
7 tasks
schans
reviewed
Jan 9, 2021
| } | ||
| selfStats, err := cgroups.GetStatsForProcess(pid) | ||
| if err != nil { | ||
| logp.Err("error getting group status: %v", err) |
There was a problem hiding this comment.
Shouldn't that be "error getting cgroup stats"? The error message puzzled me initially..
Member
Author
There was a problem hiding this comment.
Indeed :)
Thanks for pointing that out, will be fixed by #23413
bmorelli25
pushed a commit
to bmorelli25/observability-docs
that referenced
this pull request
Dec 18, 2023
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Report cgroup limits/stats on Linux, similar to what Elasticsearch reports through node stats: https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html
Metric names are based on (but not exactly the same as) the
system.process.cgroup.*fields.Why is it important?
This is important for reporting accurate resource usage in containerised environments.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.I couldn't see docs or tests to update - please point me to them if there are any.
How to test this PR locally
Related issues
Closes #14691