Cherry-pick #21113 to 7.x: libbeat/cmd/instance: report cgroup stats#21334
Merged
axw merged 2 commits intoelastic:7.xfrom Sep 30, 2020
Merged
Cherry-pick #21113 to 7.x: libbeat/cmd/instance: report cgroup stats#21334axw merged 2 commits intoelastic:7.xfrom
axw merged 2 commits intoelastic:7.xfrom
Conversation
* libbeat/cmd/instance: report cgroup stats (cherry picked from commit b4c7a93)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Gosigar's cgroups GetStatsForProcesses can return a nil Stats pointer and no error when the ["blkio", "cpu", "cpuacct", "memory"] subsystems are on the root cgroup. Related elastic#21113
Member
Author
|
Thanks @adriansr, I've cherry-picked your commit. |
adriansr
approved these changes
Sep 29, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Sep 30, 2020
2 tasks
axw
added a commit
to elastic/apm-server
that referenced
this pull request
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21113 to 7.x branch. Original message:
What does this PR do?
Report cgroup limits/stats on Linux, similar to what Elasticsearch reports through node stats: https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html
Metric names are based on (but not exactly the same as) the
system.process.cgroup.*fields.Why is it important?
This is important for reporting accurate resource usage in containerised environments.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.I couldn't see docs or tests to update - please point me to them if there are any.
How to test this PR locally
Related issues
Closes #14691