Fix autodiscover flaky tests#21242
Merged
jsoriano merged 4 commits intoelastic:masterfrom Sep 24, 2020
Merged
Conversation
Use a tagged image instead of untagged pull, this was pulling all busybox tags. Better control when the containers are started and stopped, run the container on background. Move common code to helper function.
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ChrsMark
reviewed
Sep 24, 2020
ChrsMark
reviewed
Sep 24, 2020
ChrsMark
reviewed
Sep 24, 2020
|
|
||
| self.assert_fields_are_documented(output[0]) | ||
|
|
||
| @contextmanager |
ChrsMark
approved these changes
Sep 24, 2020
Member
ChrsMark
left a comment
There was a problem hiding this comment.
lgtm in general, just 2 small questions but nothing blocker
* Import docker from the head of the file. * Check that the input is stopped before stopping filebeat.
Member
Author
|
@ChrsMark thanks for the review, I have moved the import and I continue checking that the input is stopped before stopping filebeat. Let me know what you think. |
ChrsMark
approved these changes
Sep 24, 2020
Member
ChrsMark
left a comment
There was a problem hiding this comment.
thanks, ok to merge if CI is happy
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 24, 2020
Use a tagged image instead of doing an untagged pull, this was pulling all busybox tags, busybox:latest image used now is pre-cached. Better control when the containers are started and stopped, run the container detached. Use container name instead of container image for conditions and templates, better ensuring that we are testing against the proper container. Move common code to helper function. (cherry picked from commit 0c8f82b)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 24, 2020
Use a tagged image instead of doing an untagged pull, this was pulling all busybox tags, busybox:latest image used now is pre-cached. Better control when the containers are started and stopped, run the container detached. Use container name instead of container image for conditions and templates, better ensuring that we are testing against the proper container. Move common code to helper function. (cherry picked from commit 0c8f82b)
jsoriano
added a commit
that referenced
this pull request
Sep 24, 2020
Use a tagged image instead of doing an untagged pull, this was pulling all busybox tags, busybox:latest image used now is pre-cached. Better control when the containers are started and stopped, run the container detached. Use container name instead of container image for conditions and templates, better ensuring that we are testing against the proper container. Move common code to helper function. (cherry picked from commit 0c8f82b)
jsoriano
added a commit
that referenced
this pull request
Sep 24, 2020
Use a tagged image instead of doing an untagged pull, this was pulling all busybox tags, busybox:latest image used now is pre-cached. Better control when the containers are started and stopped, run the container detached. Use container name instead of container image for conditions and templates, better ensuring that we are testing against the proper container. Move common code to helper function. (cherry picked from commit 0c8f82b)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 24, 2020
…ne-2.0 * upstream/master: (33 commits) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) Add acceptable event log keys to winlog (elastic#21205) Add elastic-agent to gitignore (elastic#21219) Add cloudfoundry tags to events (elastic#21177) [Ingest Manager] Agent includes pgp file (elastic#19480) Add compatibility note about ingress-controller-v0.34.1 (elastic#21209) [Ingest Manager] Support for UPGRADE_ACTION (elastic#21002) ...
This was referenced Sep 24, 2020
Merged
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 24, 2020
…ne-2.0-arm * upstream/master: [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 24, 2020
…-refactor * upstream/master: [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (417 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (399 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 28, 2020
* upstream/master: (60 commits) libbeat/cmd/instance: report cgroup stats (elastic#21113) Configurable index template loading (elastic#21212) [Ingest Manager] Thread safe sorted set (elastic#21290) Change mirror of kafka download (elastic#19645) [Ingest manager] Copy Action store on upgrade (elastic#21298) [CI] Pipeline 2.0 for monorepos (elastic#20104) Stop running agent container as root by default (elastic#21213) Stop running auditbeat container as root by default (elastic#21202) Fix autodiscover flaky tests (elastic#21242) [Ingest Manager] Enabled dev builds (elastic#21241) Fix librpm installation in auditbeat build (elastic#21239) Fix prometheus default config (elastic#21253) Fix dev guide test command (elastic#21254) Move aws lambda metricset to GA (elastic#21255) [Docs] Typo in table syntax (elastic#20227) [ECS] Adds related.hosts to capture all hostnames and host identifiers on an event. (elastic#21160) Add recursive split to httpjson (elastic#21214) [DOCS] Add beat specific start widgets (elastic#21217) Fix timestamp handling in remote_write (elastic#21166) Fix aws, azure and googlecloud compute dashboards (elastic#21098) ...
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#21289) Use a tagged image instead of doing an untagged pull, this was pulling all busybox tags, busybox:latest image used now is pre-cached. Better control when the containers are started and stopped, run the container detached. Use container name instead of container image for conditions and templates, better ensuring that we are testing against the proper container. Move common code to helper function. (cherry picked from commit c10ba7b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a tagged image instead of doing an untagged pull, this was pulling all
busybox tags,
busybox:latestimage used now is pre-cached.Better control when the containers are started and stopped, run the
container detached.
Use container name instead of container image for conditions and templates,
better ensuring that we are testing against the proper container.
Move common code to helper function.