[Ingest Manager] Send datastreams fields#20402
Merged
michalpristas merged 6 commits intoelastic:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
blakerouse
requested changes
Aug 3, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Missed some in the monitoring.
| "target": "datastream", | ||
| "fields": map[string]interface{}{ | ||
| "type": "logs", | ||
| "dataset": "elastic.agent", |
Contributor
There was a problem hiding this comment.
This is wrong, should be fmt.Sprintf("elastic.agent.%s", name)
| }, | ||
| }, | ||
| { | ||
| "add_fields": map[string]interface{}{ |
Contributor
There was a problem hiding this comment.
You missed adding it to getMonitoringMetricbeatConfig
Contributor
Author
There was a problem hiding this comment.
thanks, i totally missed that
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
|
blakerouse
approved these changes
Aug 3, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Looks good!
Contributor
|
@michalpristas did not test it locally but remember sometimes the processors for the monitoring data went missing. Just double checking. |
Contributor
|
@michalpristas Just saw that this PR is against master. Most importantly we will need the change in 7.9. 7.10 will be only datastreams so not a direct backport. Perhaps better to point it to 7.9 directly? |
ruflin
approved these changes
Aug 5, 2020
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Aug 5, 2020
[Ingest Manager] Send datastreams fields (elastic#20402)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Aug 5, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…ne-2.0 * upstream/master: [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…allation * upstream/master: (23 commits) [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356) New multiline mode in Filebeat: while_pattern (elastic#19662) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Send datastreams fields (elastic#20402)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
datastream.*fields as for request described here elastic/integrations#213 and elastic/elasticsearch#60592Why is it important?
Desciben in an issue here elastic/integrations#213 and elastic/elasticsearch#60592
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.cc @ruflin