[Filebeat][ATP Module]Setting user agent field required by the API#20440
Merged
adriansr merged 3 commits intoelastic:masterfrom Aug 5, 2020
Merged
[Filebeat][ATP Module]Setting user agent field required by the API#20440adriansr merged 3 commits intoelastic:masterfrom
adriansr merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
adriansr
suggested changes
Aug 5, 2020
Contributor
There was a problem hiding this comment.
This is failing for me:
Exiting: Failed to start crawler: creating module reloader failed: required 'object', but found 'string' in field 'http_headers'
It seemed to work when I added the | tojson suggested below. Got this:
GET /?%24filter=lastUpdateTime+gt+2020-08-05T08%3A01%3A03.001739Z HTTP/1.1
Host: localhost:8888
User-Agent: MdatpPartner-Elastic-Filebeat/1.0.0
Accept: application/json
Content-Type: application/json
Accept-Encoding: gzip
Connection: close
| oauth2.provider: azure | ||
| oauth2.azure.resource: https://api.securitycenter.windows.com/ | ||
|
|
||
| http_headers: {{ .http_headers }} |
Contributor
There was a problem hiding this comment.
I think this should be {{ .http_headers | tojson }}
Contributor
adriansr
approved these changes
Aug 5, 2020
adriansr
pushed a commit
to adriansr/beats
that referenced
this pull request
Aug 5, 2020
…lastic#20440) Setting user-agent field required by ATP API for monitoring purposes (cherry picked from commit 6a9a20e)
adriansr
added a commit
that referenced
this pull request
Aug 5, 2020
adriansr
pushed a commit
to adriansr/beats
that referenced
this pull request
Aug 5, 2020
…lastic#20440) Setting user-agent field required by ATP API for monitoring purposes (cherry picked from commit 6a9a20e)
adriansr
added a commit
that referenced
this pull request
Aug 5, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…ne-2.0 * upstream/master: [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 6, 2020
…allation * upstream/master: (23 commits) [docs] Promote ingest management to beta (elastic#20295) Upgrade elasticsearch client library used in tests (elastic#20405) Disable logging when pulling on python integration tests (elastic#20397) Remove pillow from testing requirements.txt (elastic#20407) [Filebeat][ATP Module]Setting user agent field required by the API (elastic#20440) [Ingest Manager] Send datastreams fields (elastic#20402) Add event.ingested to all Filebeat modules (elastic#20386) [Elastic Agent] Fix agent control socket path to always be less than 107 characters (elastic#20426) Improve cgroup_regex docs with examples (elastic#20425) Makes `metrics` config option required in app_insights (elastic#20406) Ensure install scripts only install if needed (elastic#20349) Update container name for the azure filesets (elastic#19899) Group same timestamp metrics values in app_insights metricset (elastic#20403) add_process_metadata processor adds container id even if process metadata not accessible (elastic#19767) Support "cluster" scope in Metricbeat elasticsearch module (elastic#18547) [Filebeat][SophosXG Module] Renaming module and fileset (elastic#20396) Update Suricata dashboards (elastic#20394) [Elastic Agent] Improve version, restart, enroll CLI commands (elastic#20359) Prepare home directories for docker images in a different stage (elastic#20356) New multiline mode in Filebeat: while_pattern (elastic#19662) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…lastic#20440) Setting user-agent field required by ATP API for monitoring purposes
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#20440) (elastic#20443) Setting user-agent field required by ATP API for monitoring purposes (cherry picked from commit 63612b2) Co-authored-by: Marius Iversen <pillus@chasenet.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Vendor modules are required to include a header for tracking purposes
Why is it important?
The header set is a requirement to use the ATP/MTP API. https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/get-started-partner-integration
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.