[7.9] Add datastream.* to mappings#60592
Merged
jpountz merged 2 commits intoelastic:7.9from Aug 4, 2020
Merged
Conversation
To be filled in
jpountz
reviewed
Aug 3, 2020
| "properties": { | ||
| "type": { | ||
| "type": "constant_keyword", | ||
| "value": "logs" |
Contributor
There was a problem hiding this comment.
Suggested change
| "value": "logs" | |
| "value": "metrics" |
Contributor
|
I wonder if this actually requires to be merged in 7.9 (as opposed to 7.10), given that Elasticsearch must be upgraded before Agent? |
Contributor
Author
|
Yes, as Elasticsearch will not update the template if a template is already there and we plan in 7.9 to already ship |
Contributor
|
Thanks, I had misunderstood the plan. |
6 tasks
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
6 tasks
Contributor
|
I opened #60638 and will treat this PR as a backport PR. |
6 tasks
ruflin
added a commit
to ruflin/integrations
that referenced
this pull request
Aug 4, 2020
It is planned to move from dataset.* to datastream.*. To make the path easier to 7.9 Elasticsearch (elastic/elasticsearch#60592) and the Elastic Agent already ship with the datastream.* fields. Because of this, these should also be added to the mappings of the packages.
ruflin
added a commit
to elastic/integrations
that referenced
this pull request
Aug 4, 2020
It is planned to move from dataset.* to datastream.*. To make the path easier to 7.9 Elasticsearch (elastic/elasticsearch#60592) and the Elastic Agent already ship with the datastream.* fields. Because of this, these should also be added to the mappings of the packages. The agent will ship datastream.* fields. Because of this, the import scripts can be adjusted to only use these fields. This PR doese not rename any Golang variables. This should be done in a follow up and in sync with potential changes to the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Elastic Agent ships data to dataset.*. We plant to rename this field to
datastream.type,datastream.dataset,datastream.namespaceinstead. To make the template forward compatible, we add these fields to 7.9 and newer.This will need forward porting to 7.x