Skip to content

[Filebeat] Add default_fields: false to fields.yml in aws module#19568

Merged
kaiyan-sheng merged 2 commits intoelastic:masterfrom
kaiyan-sheng:default_fields
Jul 1, 2020
Merged

[Filebeat] Add default_fields: false to fields.yml in aws module#19568
kaiyan-sheng merged 2 commits intoelastic:masterfrom
kaiyan-sheng:default_fields

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

I saw error about too many fields in Filebeat when running mage build unitTest:

Package: github.com/elastic/beats/v7/x-pack/filebeat
Test:    TestTemplate/default_field_length
template.go:75: Too many fields (1002>1000) in Filebeat index templatesettings.index.query.default_field for comfort. By default Elasticsearch has a limit of 1024 fields in a query so we need to keep the number of fields below 1024. Adding 'default_field: false' to fields or groups in a fields.yml can be used to reduce the number of text/keyword fields that end up in default_field.

So I went to check if I have default_field: false added for filesets under aws. This PR is to add the missing default_field: false for aws module.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 1, 2020
@kaiyan-sheng kaiyan-sheng added [zube]: In Review needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Jul 1, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@kaiyan-sheng kaiyan-sheng requested a review from leehinman July 1, 2020 20:09
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need a Changelog entry?

otherwise approve.

@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

Thanks! @leehinman I will add a changelog entry for this.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19568 opened]

  • Start Time: 2020-07-01T20:09:09.298+0000

  • Duration: 31 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 547
Skipped 128
Total 675

@kaiyan-sheng kaiyan-sheng merged commit 1360ff3 into elastic:master Jul 1, 2020
@kaiyan-sheng kaiyan-sheng deleted the default_fields branch July 1, 2020 22:12
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 1, 2020
kaiyan-sheng pushed a commit that referenced this pull request Jul 2, 2020
…elds.yml in aws module (#19572)

* [Filebeat] Add default_fields: false to fields.yml in aws module (#19568)

* Add default_fields: false to fields.yml in aws module

(cherry picked from commit 1360ff3)
v1v added a commit to v1v/beats that referenced this pull request Jul 3, 2020
…ne-beats

* upstream/master: (35 commits)
  [ci] fix env variable name for xpack filebeats (elastic#19617)
  Cache error responses for cloudfoundry apps metadata (elastic#19181)
  ci: user fixed type of agent (elastic#19625)
  Input v2 cursor testing (elastic#19573)
  Update Jenkinsfile to not inspect removed vendor (elastic#19610)
  Fix ordering and duplicate configs on autodiscover (elastic#19317)
  Prepare input/file for changes in the registrar (elastic#19516)
  Cursor input and manager implementation (elastic#19571)
  [Filebeat] Fix tls mapping in suricata module (elastic#19494)
  [Ingest Manager] Make Agent beta and Constraints experimental (elastic#19586)
  Accept prefix as metric_types for stackdriver metricset in GCP (elastic#19345)
  Implement memlog store operations (elastic#19533)
  introduce journalbeat/pkg in order to provide reusable shared code (elastic#19581)
  Add descriptions to HAProxy fields in Metricbeat (elastic#19561)
  ci: apm-server-update trigered only on upstream, comments, and manual triggered (elastic#19590)
  ci: enable upstream triggering on the packaging job (elastic#19589)
  ci: some jjbb improvements (elastic#19588)
  [MetricBeat] set tags correctly if the dimension value is ARN (elastic#19433)
  [Filebeat] Add default_fields: false to fields.yml in aws module (elastic#19568)
  Add publisher implementation for stateful inputs (elastic#19530)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…stic#19568)

* Add default_fields: false to fields.yml in aws module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Team:Platforms Label for the Integrations - Platforms team v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants