Accept prefix as metric_types for stackdriver metricset in GCP#19345
Merged
kaiyan-sheng merged 7 commits intoelastic:masterfrom Jul 2, 2020
kaiyan-sheng:metric_type_wildcard
Merged
Accept prefix as metric_types for stackdriver metricset in GCP#19345kaiyan-sheng merged 7 commits intoelastic:masterfrom kaiyan-sheng:metric_type_wildcard
kaiyan-sheng merged 7 commits intoelastic:masterfrom
kaiyan-sheng:metric_type_wildcard
Conversation
Contributor
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
6 tasks
Contributor
Author
|
@sorantis Does this |
Contributor
|
@kaiyan-sheng looks good! Is it possible to reuse the same parameter though? If not, then can the |
Contributor
Author
|
@sorantis Yes, when we can use the same config, why add a new one 😄 I just changed the PR to accept prefix using |
exekias
approved these changes
Jul 2, 2020
Merged
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 3, 2020
…ne-beats * upstream/master: (35 commits) [ci] fix env variable name for xpack filebeats (elastic#19617) Cache error responses for cloudfoundry apps metadata (elastic#19181) ci: user fixed type of agent (elastic#19625) Input v2 cursor testing (elastic#19573) Update Jenkinsfile to not inspect removed vendor (elastic#19610) Fix ordering and duplicate configs on autodiscover (elastic#19317) Prepare input/file for changes in the registrar (elastic#19516) Cursor input and manager implementation (elastic#19571) [Filebeat] Fix tls mapping in suricata module (elastic#19494) [Ingest Manager] Make Agent beta and Constraints experimental (elastic#19586) Accept prefix as metric_types for stackdriver metricset in GCP (elastic#19345) Implement memlog store operations (elastic#19533) introduce journalbeat/pkg in order to provide reusable shared code (elastic#19581) Add descriptions to HAProxy fields in Metricbeat (elastic#19561) ci: apm-server-update trigered only on upstream, comments, and manual triggered (elastic#19590) ci: enable upstream triggering on the packaging job (elastic#19589) ci: some jjbb improvements (elastic#19588) [MetricBeat] set tags correctly if the dimension value is ARN (elastic#19433) [Filebeat] Add default_fields: false to fields.yml in aws module (elastic#19568) Add publisher implementation for stateful inputs (elastic#19530) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…ic#19345) * Add metric_types for stackdriver metricset in GCP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add accepting prefix using
metric_typesconfig parameter intostackdrivermetricset for user to specify a prefix of the metric types instead of listing out all metric types one by one in the config.Why is it important?
This will make stackdriver configuration a lot shorter/simpler. For example, if you want to collect all instance metric types for compute service, you can use:
Instead of listing all metric types like below:
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Note: I need to spend some time on figuring out how to mock GCP APIs or add integration tests for GCP overall in a separate PR.
How to test this PR locally
Enable
googlecloudmodule and change googlecloud.yml to:Start Metricbeat and you should see these cpu metrics collected:
Note:
googlecloud.stackdriver.instance.cpu.scheduler_wait_timemight not exist because it is only available for VMs that belong to the e2 family and it's for measuring the wait time for vCPU is ready to run but unexpectedly not scheduled to run.