Skip to content

Cherry-pick #19568 to 7.x: [Filebeat] Add default_fields: false to fields.yml in aws module#19572

Merged
kaiyan-sheng merged 3 commits intoelastic:7.xfrom
kaiyan-sheng:backport_19568_7.x
Jul 2, 2020
Merged

Cherry-pick #19568 to 7.x: [Filebeat] Add default_fields: false to fields.yml in aws module#19572
kaiyan-sheng merged 3 commits intoelastic:7.xfrom
kaiyan-sheng:backport_19568_7.x

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 1, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #19568 to 7.x branch. Original message:

I saw error about too many fields in Filebeat when running mage build unitTest:

Package: github.com/elastic/beats/v7/x-pack/filebeat
Test:    TestTemplate/default_field_length
template.go:75: Too many fields (1002>1000) in Filebeat index templatesettings.index.query.default_field for comfort. By default Elasticsearch has a limit of 1024 fields in a query so we need to keep the number of fields below 1024. Adding 'default_field: false' to fields or groups in a fields.yml can be used to reduce the number of text/keyword fields that end up in default_field.

So I went to check if I have default_field: false added for filesets under aws. This PR is to add the missing default_field: false for aws module.

[Filebeat] Add default_fields: false to fields.yml in aws module (#19568
73e728c 
)

* Add default_fields: false to fields.yml in aws module

(cherry picked from commit 1360ff3)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jul 1, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 1, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 1, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 1, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19572 updated]

  • Start Time: 2020-07-02T18:30:37.287+0000

  • Duration: 33 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 547
Skipped 128
Total 675

jsoriano
jsoriano reviewed Jul 2, 2020
View reviewed changes
@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Jul 2, 2020

CHANGELOG file has conflicts :(

@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

kaiyan-sheng commented Jul 2, 2020

@ycombinator I guess we have a lot of cherrypicks going on right now 😄 Just resolved the conflict! Thanks!

ycombinator
ycombinator approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaiyan-sheng kaiyan-sheng merged commit 4869d15 into elastic:7.x Jul 2, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_19568_7.x branch July 2, 2020 19:54
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano left review comments

@ycombinator ycombinator ycombinator approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiyan-sheng @elasticmachine @ycombinator @jsoriano