Code style fix on the whole repo#536
Merged
gregkalapos merged 1 commit intoelastic:masterfrom Oct 12, 2019
gregkalapos:DotNetFormatWithAllCodeStyleFix
Merged
Code style fix on the whole repo#536gregkalapos merged 1 commit intoelastic:masterfrom gregkalapos:DotNetFormatWithAllCodeStyleFix
gregkalapos merged 1 commit intoelastic:masterfrom
gregkalapos:DotNetFormatWithAllCodeStyleFix
Conversation
Mpdreamz
approved these changes
Oct 9, 2019
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, I mentioned before the cleanup of js files is less then ideal but to hide these selectively in a way that is persisted in the repository settings is not straightforward.
Be good to get this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge of #532 and #535 - enabling code style fix and also fixing all code style violations.This should be green in CI, but I'd say #532 and #535 should be merged separately (#535 first) and this will be not merged.Update: #551 made my auto reformat out of date. I rebased this on
masterincluding #551 and will merge this to auto cleanup the whole repo. #532 will be merged after this.I'd also take the opportunity to say sorry to everyone whose PR I made conflicting with this, including my own PRs :) - Long term this'll make things better!