Update .editorconfig #532#551
Merged
gregkalapos merged 1 commit intoelastic:masterfrom Oct 12, 2019
gregkalapos:editorconfigrevert
Merged
Update .editorconfig #532#551gregkalapos merged 1 commit intoelastic:masterfrom gregkalapos:editorconfigrevert
gregkalapos merged 1 commit intoelastic:masterfrom
gregkalapos:editorconfigrevert
Conversation
The `.editorconfig` was changed in #497. That PR was about "Central Config Implementation". Let's revert the `.editorconfig` change and in case we really want to change it please do it in a separate PR.
Mpdreamz
approved these changes
Oct 12, 2019
This was referenced Oct 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.editorconfigwas changed in #497.That PR was about "Central Config Implementation". Let's revert the
.editorconfigchange and in case we really want to change it please do it in a separate PR. Also as agreed we should keep.editorconfigin sync across .NET repos at elastic - or at least make it very similar.#532 and #535 take care of making the errors go away and from this point we have CI support to enforce the correct code style.
Mainly noticed because of
csharp_style_expression_bodied_methods = true:errorwas changed totrue:none. That'd cause not reformatting one liners to expression bodied methods, while we already have lots of existing expression bodied methods - let's try to keep this unified and not change for now.