Fix all code style violations#535
Closed
gregkalapos wants to merge 2 commits intoelastic:masterfrom
gregkalapos:CodeStyle_AutoCleanup
Closed
Fix all code style violations#535gregkalapos wants to merge 2 commits intoelastic:masterfrom gregkalapos:CodeStyle_AutoCleanup
gregkalapos wants to merge 2 commits intoelastic:masterfrom
gregkalapos:CodeStyle_AutoCleanup
Conversation
This was referenced Oct 4, 2019
Closed
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 84.01% 83.78% -0.24%
==========================================
Files 101 101
Lines 4480 4415 -65
==========================================
- Hits 3764 3699 -65
Misses 716 716
Continue to review full report at Codecov.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#532 adds
dotnet formatchecks to make sure all PRs respect our.editorconfig. Currently #532 fails, because we already have lots of violations in our code base. This PR fixes those.All done by auto code cleanup - there is no manual code change here. I think this does not need too much manual review, it'd be very hard to do anyway.