Add missing version-ranges to implicit imports of tycho.surefire.junit5#5526
Merged
HannesWell merged 1 commit intoOct 25, 2025
Merged
Conversation
Without them Junit-6 bundles are automatically added to the test-runtime, even if the tested project actually only depends on junit-5 packages/bundles. The only way to prevent it, was to add implicitly required platform and engine bundles explicitly to the test projects.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Oct 25, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - eclipse-pde#2004 - eclipse-pde#2054
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
HannesWell
added a commit
to HannesWell/eclipse.platform.releng.aggregator
that referenced
this pull request
Oct 25, 2025
This makes the fix to not mix JUnit-5 and JUnit-6 bundles in a test-runtime, if both are in the target-platform but only JUnit-5 is actually referenced: - eclipse-tycho/tycho#5526
iloveeclipse
pushed a commit
to eclipse-platform/eclipse.platform.releng.aggregator
that referenced
this pull request
Oct 26, 2025
This makes the fix to not mix JUnit-5 and JUnit-6 bundles in a test-runtime, if both are in the target-platform but only JUnit-5 is actually referenced: - eclipse-tycho/tycho#5526
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Oct 26, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - eclipse-pde#2004 - eclipse-pde#2054
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Oct 26, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - eclipse-pde#2004 - eclipse-pde#2054
HannesWell
added a commit
to eclipse-pde/eclipse.pde
that referenced
this pull request
Oct 27, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - #2004 - #2054
trancexpress
pushed a commit
to trancexpress/eclipse.pde
that referenced
this pull request
Nov 10, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - eclipse-pde#2004 - eclipse-pde#2054
amelodev
pushed a commit
to amelodev/eclipse.pde
that referenced
this pull request
Nov 13, 2025
After a bug fix in Tycho it's not necessary anymore to specify the complete set of junit bundles explicitly, in order to ensure that JUnit-6 bundles are not present: - eclipse-tycho/tycho#5526 This reverts most of the workarounds from - eclipse-pde#2004 - eclipse-pde#2054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without them Junit-6 bundles are automatically added to the test-runtime, even if the tested project actually only depends on junit-5 packages/bundles.
The only way to prevent it, was to add implicitly required platform and engine bundles explicitly to the test projects.