Skip to content

Workaround for failure in test execution#2054

Merged
laeubi merged 1 commit into
eclipse-pde:masterfrom
laeubi:fix_test_failures
Oct 24, 2025
Merged

Workaround for failure in test execution#2054
laeubi merged 1 commit into
eclipse-pde:masterfrom
laeubi:fix_test_failures

Conversation

@laeubi

@laeubi laeubi commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

This pull request updates the test dependencies for several Eclipse plugin test bundles to include additional JUnit 5 Platform Suite components. These changes ensure that the test bundles have all necessary dependencies for running JUnit 5 tests, improving compatibility and test execution reliability.

JUnit 5 Platform Suite dependency updates:

  • Added junit-platform-suite-commons and junit-platform-suite-engine to the required bundles in META-INF/MANIFEST.MF for the following test projects:
    • org.eclipse.e4.tools.compatibility.migration.tests
    • org.eclipse.e4.tools.persistence.tests
    • org.eclipse.pde.ds.tests

Other dependency management:

  • Removed explicit Import-Package entries for JUnit 5 packages from org.eclipse.pde.ds.tests and replaced them with Require-Bundle entries, streamlining dependency management.

@laeubi laeubi force-pushed the fix_test_failures branch from b03f3f8 to 952a10f Compare October 24, 2025 10:13
@akurtakov

Copy link
Copy Markdown
Member

It would be nice to explain what the workaround is and why is it needed in the commit message and PR.

@laeubi

laeubi commented Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

why is it needed

https://ci.eclipse.org/pde/job/eclipse.pde/job/master/12/ and all Verification PRs currently fail

what the workaround

Use require bundle with version ranges on the core JUnit 5 bundles.

@github-actions

Copy link
Copy Markdown

Test Results

   774 files  +36     774 suites  +36   1h 20m 3s ⏱️ + 6m 59s
 3 631 tests +48   3 579 ✅ +48   52 💤 ±0  0 ❌ ±0 
10 827 runs  +78  10 670 ✅ +78  157 💤 ±0  0 ❌ ±0 

Results for commit b44c245. ± Comparison against base commit f32bebf.

@laeubi laeubi merged commit d4e4759 into eclipse-pde:master Oct 24, 2025
19 checks passed
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 25, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 26, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 26, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
HannesWell added a commit that referenced this pull request Oct 27, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- #2004
- #2054
trancexpress pushed a commit to trancexpress/eclipse.pde that referenced this pull request Nov 10, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
amelodev pushed a commit to amelodev/eclipse.pde that referenced this pull request Nov 13, 2025
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants