Skip to content

Restrict failing pde tests to use junit5 dependencies#2004

Merged
merks merged 2 commits into
eclipse-pde:masterfrom
merks:pr-fix-pde-build-test
Oct 9, 2025
Merged

Restrict failing pde tests to use junit5 dependencies#2004
merks merged 2 commits into
eclipse-pde:masterfrom
merks:pr-fix-pde-build-test

Conversation

@merks

@merks merks commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@eclipse-pde-bot

eclipse-pde-bot commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.junit.runtime.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 777688634f7b27e4a4aa22e932634d17e728671c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Thu, 9 Oct 2025 17:43:28 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
index 64b59fcfc5..4934376dd9 100644
--- a/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: PDE JUnit Runtime Tests
 Bundle-SymbolicName: org.eclipse.pde.junit.runtime.tests;singleton:=true
-Bundle-Version: 3.8.100.qualifier
+Bundle-Version: 3.8.200.qualifier
 Automatic-Module-Name: org.eclipse.pde.junit.runtime.tests
 Bundle-RequiredExecutionEnvironment: JavaSE-21
 Bundle-Vendor: Eclipse.org
diff --git a/ui/org.eclipse.pde.junit.runtime.tests/pom.xml b/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
index 6ac0145a8d..19feaeca8e 100644
--- a/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
+++ b/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
@@ -24,7 +24,7 @@
 		<relativePath>../../</relativePath>
 	</parent>
 	<artifactId>org.eclipse.pde.junit.runtime.tests</artifactId>
-	<version>3.8.100-SNAPSHOT</version>
+	<version>3.8.200-SNAPSHOT</version>
 	<packaging>eclipse-test-plugin</packaging>
 	<build>
 		<plugins>
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results

   732 files  + 78     732 suites  +78   52m 36s ⏱️ + 28m 50s
 3 610 tests +306   3 557 ✅ +278   53 💤 +28  0 ❌ ±0 
10 830 runs  +918  10 670 ✅ +833  160 💤 +85  0 ❌ ±0 

Results for commit bfd2ec3. ± Comparison against base commit b4eeb39.

♻️ This comment has been updated with latest results.

@merks merks force-pushed the pr-fix-pde-build-test branch from 330fa98 to 76c0001 Compare October 9, 2025 12:55
@HeikoKlare HeikoKlare mentioned this pull request Oct 9, 2025
Merged
@merks

merks commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

FYI, the org.eclipse.pde.ds.tck test is really special with all kinds of black box processing that's completely opaque to me. Maybe tomorrow I have a brilliant idea, but at this point I don't see how it builds it's dependencies and find things that I would prefer it not find.

@HeikoKlare HeikoKlare mentioned this pull request Oct 9, 2025
Merged
@merks
Restrict failing pde tests to use junit5 dependencies
fc9e380 
- Disable org.eclipse.pde.ds.tck until we can figure out how to make it
work.
@merks merks force-pushed the pr-fix-pde-build-test branch from f30b742 to fc9e380 Compare October 9, 2025 17:40
@merks

merks commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

image

@merks merks merged commit 01bf84c into eclipse-pde:master Oct 9, 2025
19 checks passed
@merks merks deleted the pr-fix-pde-build-test branch October 9, 2025 18:30
@merks merks mentioned this pull request Oct 9, 2025
Open
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 25, 2025
@HannesWell
Import only junit-5 packages required for compilation in tests
4873ec4 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
@HannesWell HannesWell mentioned this pull request Oct 25, 2025
Merged
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 26, 2025
@HannesWell
Import only junit-5 packages required for compilation in tests
c9a3b20 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 26, 2025
@HannesWell
Import only junit-5 packages required for compilation in tests
10c1449 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
HannesWell added a commit that referenced this pull request Oct 27, 2025
@HannesWell
Import only junit-5 packages required for compilation in tests
e5ecc3a 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- #2004
- #2054
trancexpress pushed a commit to trancexpress/eclipse.pde that referenced this pull request Nov 10, 2025
@HannesWell @trancexpress
Import only junit-5 packages required for compilation in tests
2e9dc7d 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
amelodev pushed a commit to amelodev/eclipse.pde that referenced this pull request Nov 13, 2025
@HannesWell @amelodev
Import only junit-5 packages required for compilation in tests
7a3d89e 
After a bug fix in Tycho it's not necessary anymore to specify the
complete set of junit bundles explicitly, in order to ensure that
JUnit-6 bundles are not present:
- eclipse-tycho/tycho#5526

This reverts most of the workarounds from
- eclipse-pde#2004
- eclipse-pde#2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@merks @eclipse-pde-bot